Re: [BUG] org-refile-get-location a symlinked file [9.7-pre (release_9.6.29-1443-gb4d17c)]

[Ihor Radchenko <yantar92@posteo.net>]

Al Haji-Ali <abdo.haji.ali@gmail.com> writes:

>> I am thus attaching an alternative patch.
>> May you please test if it fixes the problem on your side?
> I think it's missing calling `file-truename` call on `filename`, see attached patch.

Makes sense.
Applied, onto bugfix.
Fixed.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?h=bugfix&id=a4ff518

>> Thanks. Although this is a different kind of patch. And it is doing too
>> much - we do not want to expand all the names via `file-truename'
>> because you may have a situation like
>>
>> /path/to/file1.org
>> /path/to/symlinks/name-is-completely-different.org
>>
>> Then, using `file-truename' may be confusing for people who expect the
>> symlink name to be displayed.
>
> I am not sure what would be the correct approach. Perhaps the
> true-name expansion should be conditioned on the value of
> `find-file-visit-truename`.

Maybe. I am slightly cautious about adding it without public discussion
though - (1) I can see how people may not expect
`find-file-visit-truename` to affect `org-refile'; (2) I am not 100%
familiar with this area of Org codebase, and I am not 100% confident that
changing refile targets table won't break anything.

If you want to add support of `find-file-visit-truename`, please send
another email marked [FR] (feature request) in subject line, explaining
what you want to add. Then, we can see if more people are interested.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>