all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Al Haji-Ali <abdo.haji.ali@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] org-refile-get-location a symlinked file [9.7-pre (release_9.6.29-1443-gb4d17c)]
Date: Thu, 20 Jun 2024 14:56:37 +0000	[thread overview]
Message-ID: <871q4r8xy2.fsf@localhost> (raw)
In-Reply-To: <m2tthoniwj.fsf@gmail.com>

Al Haji-Ali <abdo.haji.ali@gmail.com> writes:

>> I am thus attaching an alternative patch.
>> May you please test if it fixes the problem on your side?
> I think it's missing calling `file-truename` call on `filename`, see attached patch.

Makes sense.
Applied, onto bugfix.
Fixed.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?h=bugfix&id=a4ff518

>> Thanks. Although this is a different kind of patch. And it is doing too
>> much - we do not want to expand all the names via `file-truename'
>> because you may have a situation like
>>
>> /path/to/file1.org
>> /path/to/symlinks/name-is-completely-different.org
>>
>> Then, using `file-truename' may be confusing for people who expect the
>> symlink name to be displayed.
>
> I am not sure what would be the correct approach. Perhaps the
> true-name expansion should be conditioned on the value of
> `find-file-visit-truename`.

Maybe. I am slightly cautious about adding it without public discussion
though - (1) I can see how people may not expect
`find-file-visit-truename` to affect `org-refile'; (2) I am not 100%
familiar with this area of Org codebase, and I am not 100% confident that
changing refile targets table won't break anything.

If you want to add support of `find-file-visit-truename`, please send
another email marked [FR] (feature request) in subject line, explaining
what you want to add. Then, we can see if more people are interested.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2024-06-20 14:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-17 15:51 [BUG] org-refile-get-location a symlinked file [9.7-pre (release_9.6.29-1443-gb4d17c)] Al Haji-Ali
2024-06-17 17:26 ` Ihor Radchenko
2024-06-17 21:52   ` Al Haji-Ali
2024-06-18 12:56     ` Ihor Radchenko
2024-06-18 18:53       ` Al Haji-Ali
2024-06-19 14:25         ` Ihor Radchenko
2024-06-20  8:00           ` Al Haji-Ali
2024-06-20 14:56             ` Ihor Radchenko [this message]
2024-06-20 15:13               ` Al Haji-Ali
2024-06-20 15:26                 ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871q4r8xy2.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=abdo.haji.ali@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.