From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: MPS: Crash while completing symbol with corfu Date: Tue, 02 Jul 2024 15:14:16 +0000 Message-ID: <871q4b6d2v.fsf@localhost> References: <87y16lbh10.fsf@localhost> <86v81pduw3.fsf@gnu.org> <87sewt87ni.fsf@localhost> <4aK6qyh6gPCldT2u0rLYOuIk7a5Coo8yNf71tkkBOlUh0yk3nU8yjRAZygm9rIzK3kOcyq_IAatIKS2buH7tgA2PwHIOgLTiqQRSoypoOfY=@protonmail.com> <871q4cja54.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26893"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Gerd =?utf-8?Q?M=C3=B6llmann?= , emacs-devel@gnu.org, eller.helmut@gmail.com To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 02 17:13:36 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sOfCK-0006mk-Dg for ged-emacs-devel@m.gmane-mx.org; Tue, 02 Jul 2024 17:13:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sOfBY-0004Tq-QC; Tue, 02 Jul 2024 11:12:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOfBW-0004Tb-GC for emacs-devel@gnu.org; Tue, 02 Jul 2024 11:12:46 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sOfBT-00079q-F7 for emacs-devel@gnu.org; Tue, 02 Jul 2024 11:12:46 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 186AC24002A for ; Tue, 2 Jul 2024 17:12:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1719933160; bh=TotrG2+D1tntmFkW1aopI7hR0hi37MqMiJ7WfIaMNSs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=U58JvU6oSAjB7QKAHkXbB3OQCwh+YaxEiZucxMgYNJz7OHdsyzW4lHWQGGxQ/eQ3V r+8tORsfOTsqd58mQwrqqFMND4Cvw880ABJ8O4H5RUSxzxaD5iUw13LDURoDAjoo1g BHKcwx1SUvg2OyE7CYih1cYJF5xf9EmYPSrW7BOjzUk+gmRSFQhXlEI737CgH33Vdr HsPSO7TACZi3Fs/KiJCt7RSxyiZRWs5Dh+7nl/rX5Tncj5ZS13HX16aF20PxWZ1M+5 RcDCetPKpcamcI/u0cfmm5ylGDyjVpnlP3z9xHjYhg3J8UaewWXoLkOauBTDmz4nAw QM8isJcoJ1v9Q== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4WD5xf63yqz6twY; Tue, 2 Jul 2024 17:12:38 +0200 (CEST) In-Reply-To: Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321172 Archived-At: Pip Cet writes: > Oops, turns out you shouldn't double free just to be sure. > > Can you try the attached patch? I was able to trigger your bug by running > > ./emacs -Q --eval "(while t (menu-bar-mode 'toggle) (sit-for 0.1))" > > The change is in menu_destroy_callback, which passed through the wrong pointer. No immediate crashes now. I will keep this session running, with your patches installed. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at