From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jeremy Bryant via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#71374: [PATCH] Simplify 'help-enable-variable-value-editing' using Date: Sat, 13 Jul 2024 22:53:20 +0100 Message-ID: <871q3xklgv.fsf@jeremybryant.net> References: <87ikync1zh.fsf@posteo.net> <86frtrk2ec.fsf@gnu.org> <8734pqbneq.fsf@posteo.net> Reply-To: Jeremy Bryant Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6857"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philip Kaludercic , Eli Zaretskii , 71374@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 13 23:55:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sSki5-0001ZG-V7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Jul 2024 23:55:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sSkhs-00023Q-Nw; Sat, 13 Jul 2024 17:55:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sSkhq-00023H-6D for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2024 17:55:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sSkhp-0005yj-1P for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2024 17:55:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sSkhq-0005kh-0u for bug-gnu-emacs@gnu.org; Sat, 13 Jul 2024 17:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jeremy Bryant Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Jul 2024 21:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71374 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71374-submit@debbugs.gnu.org id=B71374.172090764222024 (code B ref 71374); Sat, 13 Jul 2024 21:55:01 +0000 Original-Received: (at 71374) by debbugs.gnu.org; 13 Jul 2024 21:54:02 +0000 Original-Received: from localhost ([127.0.0.1]:56905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSkgs-0005jA-Ae for submit@debbugs.gnu.org; Sat, 13 Jul 2024 17:54:02 -0400 Original-Received: from out-186.mta1.migadu.com ([95.215.58.186]:23083) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSkgp-0005if-Sj for 71374@debbugs.gnu.org; Sat, 13 Jul 2024 17:54:01 -0400 X-Envelope-To: 71374@debbugs.gnu.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jeremybryant.net; s=key1; t=1720907602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JOwl4EpBaLuf2V2bh8+DoRFAfy70l9xsByT6IHfkZEY=; b=E1GOeQ/Os28cOSuUn7PK98Yw18feW+Av1lOaFepHPq2wOrClczFfUZN8a7jktXus0PLGEy bxxRdnAmDQUCm1fWQpKrRjuAGMFmFwCvdoeYD96lb49pxjE/ifcg+VGJFbUxCQ0QCffUAc l5B7xYMS8t/PV2zhaCmeTsbtuPJb8tODSLOI3pdxelWKsTbRaHTLHK9wRgQk/UHehywKEi EIgaEXdHzRg8+SmmSLmhZygBK88PNRMvlTw2qvmZnZmvM9LVd0DxUNLUbVJyvA7DOFiSMg Fpljd5ms9CV811FXIOCWg9duNjrOWh+vMGs4upcFGl4ewS9nPO1JCrbstsCwpQ== X-Envelope-To: eliz@gnu.org X-Envelope-To: philipk@posteo.net X-Envelope-To: stefankangas@gmail.com X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: (Stefan Kangas's message of "Sat, 29 Jun 2024 22:38:42 -0700") X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288827 Archived-At: Stefan Kangas writes: > Philip Kaludercic writes: > >> Eli Zaretskii writes: >> >>>> From: Philip Kaludercic >>>> Date: Wed, 05 Jun 2024 06:55:46 +0000 >>>> >>>> The main issue with this patch is that it drops the syntax highlighting >>>> in the *string edit* buffer, but we could fix that in a second patch by >>>> adding support to specify a major mode to inherit from when editing a >>>> string. >>> >>> Thanks. This is basically a cleanup, yes? IOW, there's nothing wrong >>> with the current implementation, right? If so, I'd prefer to wait >>> with this until after the emacs-30 branch is cut. >> >> Right, it just seemed like the kind of thing where it would be natural >> to demonstrate string-edit. > > Feel free to install on master now, thanks. Philip, has this been installed on master? Can the bug be closed?