From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#72141: 29.4; package-upgrade vs package-load-list Date: Sun, 28 Jul 2024 11:47:44 +0000 Message-ID: <871q3drb4v.fsf@posteo.net> References: <87ikx5xulu.fsf@posteo.net> <865xsr2tn0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31438"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Thierry Volpiatto , 72141@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 28 13:49:07 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sY2Og-00083E-RD for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 28 Jul 2024 13:49:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sY2OT-0006OV-QS; Sun, 28 Jul 2024 07:48:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sY2OR-0006OF-FC for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2024 07:48:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sY2OR-0000vG-5N for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2024 07:48:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=h1hMKD6RrNHmvDsn1/OKdQD9mRUU94UkGjz1rfcNRPA=; b=RDRgCmwGiiSJRZJToFKZSH56iNXkddrf+UBFQ9gGXQTpUNcFbQTPxb+++V29rqAJOJqaHNyeES53off58BQa7iJfN2/epGWUGEEC7lA+QP96gg3wwnYyoORWYvC7z83maYAoTxfixZaq5PdTiAJBR5OYdcwT+q4nWvrp9r3UvbV0I7w2yVKPKP41+9whJseqI0mWNOCXm7y4ey3k8CMOXcl988U20E7AQUZk0q5a1rLRSeEZNEnRGIyI6S8OJIRryZ0lSoTTYN/mUBC2iugZp04xxF7cCKOIz8T3RMA3c5p2EhZg82bYIrdNgCSZMzeOgzQy+akDlilGKgWWxrad1Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sY2Oc-0006Hh-8v for bug-gnu-emacs@gnu.org; Sun, 28 Jul 2024 07:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jul 2024 11:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72141 X-GNU-PR-Package: emacs Original-Received: via spool by 72141-submit@debbugs.gnu.org id=B72141.172216728924098 (code B ref 72141); Sun, 28 Jul 2024 11:49:02 +0000 Original-Received: (at 72141) by debbugs.gnu.org; 28 Jul 2024 11:48:09 +0000 Original-Received: from localhost ([127.0.0.1]:42747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sY2Nk-0006Gc-KA for submit@debbugs.gnu.org; Sun, 28 Jul 2024 07:48:08 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:52845) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sY2Ng-0006G6-Nx for 72141@debbugs.gnu.org; Sun, 28 Jul 2024 07:48:06 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 8D6D1240103 for <72141@debbugs.gnu.org>; Sun, 28 Jul 2024 13:47:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1722167266; bh=8Eb4T1ze77u9W+9XajDzyWoWjd0bdqDA20yGJ17FNMo=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=D71Jwy2VS+nyBk+7XOus/0/6QHL6i0mbyoyJQDPOsMqXYhDMGWHcyxbk2pAbGK1U0 nD1zxlUy3r6xeGhehwRmkUfdJBllJL8ULVpAtEzoT2FdSmy0CkgkrdfnwZQn1LO+mD 25iaZE+9t0KADJ8cujBrkIfZsWNPeUheTrnQYFvpKWvZJpXDLhpqKV59WevsueNY4d uDoIQJ/di1aCipv8hLrmL5SIyiWW6mNDeQ45RZhhFYsHC3GHcbSZOTyo2PN2BbApC0 +VEFPXQbdZm682h4ZL75XOIoP+gO4qsZdCFoXH6Yw/wpZQipcBQjhWfBFs/hDKPXS+ HC50ERpRuzk6w== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4WX09F3shzz6tw5; Sun, 28 Jul 2024 13:47:45 +0200 (CEST) In-Reply-To: <865xsr2tn0.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 27 Jul 2024 10:14:59 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289462 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Thierry Volpiatto >> Date: Tue, 16 Jul 2024 14:46:37 +0000 >> >> >> I think there is a bug here, but please verify with following recipe as >> I don't use widely package installation, at least for myself. When reading >> the code I believe it is reproductible as well on emacs-30+. >> >> 1) Install package foo and bar. >> 2) Disable them in package-load-list ((foo nil) (bar nil) all). >> 3) Wait some time until foo and/or bar have new versions available. >> 4) Call package-upgrade-all. It will call package-upgrade on foo >> and bar (and possibly others). When package-upgrade find foo >> package it will (1) delete it and (2) call package-install which >> will refuse to install (error) because foo is disabled. >> >> As a result we have lost foo package, it is now uninstalled. >> Same problem with M-x package-upgrade, foo and bar are listed in >> completion and made available whereas they are going to fail to >> upgrade. > > Philip, any comments or suggestions? The issue is that we don't install a package if it is disabled. So either we allow installing (but don't activate) disabled packages, or we ignore disabled packages during upgrades. That might just need this change: --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 7cae8d68bc0..eb77d99fad2 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -2286,6 +2286,9 @@ package--upgradeable-packages (or (let ((available (assq (car elt) package-archive-contents))) (and available + (package-disabled-p + (cadr elt) + (package-desc-version (cadr elt))) (or (and include-builtins (not (package-desc-version (cadr elt)))) --=-=-= Content-Type: text/plain -- Philip Kaludercic on peregrine --=-=-=--