From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Steven Allen via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#72323: 31.0.50; line-move unconditionally resets vscroll to 0 Date: Sun, 18 Aug 2024 15:17:48 -0700 Message-ID: <871q2l5vcj.fsf@stebalien.com> References: <87zfq2hg4n.fsf@stebalien.com> <86ikwq1z92.fsf@gnu.org> <87v80qha04.fsf@stebalien.com> <86cymy15n2.fsf@gnu.org> <877cd59t76.fsf@stebalien.com> <86jzh4zc2w.fsf@gnu.org> <877ccd3f56.fsf@stebalien.com> <86wmkdy9mx.fsf@gnu.org> <871q2l3c9h.fsf@stebalien.com> <86r0aly7s5.fsf@gnu.org> Reply-To: Steven Allen Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8326"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 72323@debbugs.gnu.org, storm@cua.dk To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 19 00:18:55 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sfoEd-00020J-TU for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Aug 2024 00:18:52 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sfoEE-0002HD-SH; Sun, 18 Aug 2024 18:18:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sfoEA-0002Gt-4v for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2024 18:18:23 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sfoE9-0005AT-Lp for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2024 18:18:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=uwzmQlHv8euc6+cs45DGHEno1Tt8Bl3QO8sksU1DQiw=; b=gtd8D6QkSYx40B4XUxgUmKA09paMOte5G+P0EVIe7EPKaDddNF8kZduu2a24GMMxHQOChmbx8i4Qvzo/bAlrtlOuzF8RGBSvxtp/SIujptCsW4UddjN1Xv96bTaHO95Pep7s63t2iWjO3L7VBjey8wDmgCUdNkFmfk05efv4HMNc5Qtn0cpwPpygNBge8k7we65HoZrEt6PS6Y/qSI7lWOAbES7fAZ2PmJNJn1L4OLlJoaczrTMxTOXO1DtMutqpKPnXkdcpTeOGFuO1elZEjWmUGLkKbyRiW5xZ4dN8m0q0FAmzhd9C1Z54L3A9LM5wYEIE8YWe6VpN9noyD1LRrw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sfoEo-0004RI-5r for bug-gnu-emacs@gnu.org; Sun, 18 Aug 2024 18:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Steven Allen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Aug 2024 22:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72323 X-GNU-PR-Package: emacs Original-Received: via spool by 72323-submit@debbugs.gnu.org id=B72323.172401951917036 (code B ref 72323); Sun, 18 Aug 2024 22:19:02 +0000 Original-Received: (at 72323) by debbugs.gnu.org; 18 Aug 2024 22:18:39 +0000 Original-Received: from localhost ([127.0.0.1]:56944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfoER-0004Qh-4F for submit@debbugs.gnu.org; Sun, 18 Aug 2024 18:18:39 -0400 Original-Received: from fhigh7-smtp.messagingengine.com ([103.168.172.158]:53221) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sfoEO-0004QS-U0 for 72323@debbugs.gnu.org; Sun, 18 Aug 2024 18:18:37 -0400 Original-Received: from phl-compute-02.internal (phl-compute-02.nyi.internal [10.202.2.42]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 98595114B020; Sun, 18 Aug 2024 18:17:50 -0400 (EDT) Original-Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-02.internal (MEProxy); Sun, 18 Aug 2024 18:17:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm2; t=1724019470; x= 1724105870; bh=uwzmQlHv8euc6+cs45DGHEno1Tt8Bl3QO8sksU1DQiw=; b=c GnHw2EhqipnmrIWApsz1pESSpA+uStVum1N2vF2KAphKKbTAY1gc6QZSN7Gwfp7g UXSwzf7eofOSI0bYFTleeY684Vw25gTmNlPNQR0AmvVlfo3pdC6cVr3w1Ux2T8lN TJllIOB9LTCVy788hbA39YaNocBR/cLmlgscsueDu3unUhG3/WyVf/wRGZ51uIBd POtTGVcyCKYEz8LJvoz8iahSwJGwuhJk+F32NuZ5823jUAtCjhj7ITf37XxmFy6i bq3/nJ5n2Aegblve6QtztxaUxm7fOh5vZmrcrYtcOLpSblEvC2BAc3yWxnPvuNM0 d7mtIM29PmumzHdyn7q6w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1724019470; x=1724105870; bh=uwzmQlHv8euc6+cs45DGHEno1Tt8 Bl3QO8sksU1DQiw=; b=iZDJGI2dpiA+MKT9aNnfYgXWvQmeLSbqvuY+0cQkU9b+ F79G94ineiEuKiUadhrBsg2tS4SI9DzwNVYH+SaUfgsNDqukU5smmJTOsZy1pMHy UOgIHjDV4v9ln4XTx+fJECK/edks/738encPkgwmGmehMbJ8u5zzjwrtpQ74dyKK 7rnAKUMx1vugEqs6v0jAtu5L3aB5tMb8YAT1Aif6u4EDvqoPYDuALTINY1qBrS36 ETGDmtLTZNidZRwJykUkCuYzjDduIyPlGe2OtGHnyxsSyYRwX0K1aD7n5dH9dh/y X1ROIUFrq2iZtKNGzvJ1sW3LP6dm9eMyaZ2tRLmmlw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddruddufedgtdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffffkgggtsehttdertddttddtnecu hfhrohhmpefuthgvvhgvnhcutehllhgvnhcuoehsthgvvhgvnhesshhtvggsrghlihgvnh drtghomheqnecuggftrfgrthhtvghrnhepvdekheekgeelheehgefgudelkeethffhgfeu ffetkeegtddvfeduuddttdejjedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepshhtvghvvghnsehsthgvsggrlhhivghnrdgtohhmpdhnsggp rhgtphhtthhopeegpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegvlhhiiiesgh hnuhdrohhrghdprhgtphhtthhopehluhgrnhhgrhhuoheshigrhhhoohdrtghomhdprhgt phhtthhopeejvdefvdefseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepsh htohhrmhestghurgdrughk X-ME-Proxy: Feedback-ID: ie8a146a7:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 18 Aug 2024 18:17:49 -0400 (EDT) In-Reply-To: <86r0aly7s5.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290361 Archived-At: Eli Zaretskii writes: >> > I disagree. When point moves to another screen line without moving >> > window-start, vscroll may or may not be valid. Whether it is depends >> > on the details of what is on display. >> >> Can you give me an example example where moving point invalidates >> vscroll (except when point would move partially or fully off screen)? > > Why isn't the one example I gave enough? > > The code in question doesn't know whether this is or isn't the case, > at least not in all cases and not without a lot of tedious layout > calculations. Whether the current line will be fully visible is only > known after the window is redisplayed. At which time we also check > that we didn't enter the scroll margins and other conditions that > require to scroll the window. Keeping the vscroll would make all this > much more complicated, so we play it safe. I just wanted to confirm that the issue is specifically about the being fully visible and not something else I'm missing. If that's the case, I'll see if I can hack something up for my own use and, if usable, see if it's possible to integrate into pixel-scroll-precision-mode. But it'll have to be an advice as line-move is called all over the place. It really sounds like you just don't want to mess with this function which is a reasonable stance as the maintainer. But it was really hard to tell if there was something I was fundamentally misunderstanding or if you were just being cautious and not wanting to touch a complex piece of machinery if it's working "well enough".