From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#73004: [PATCH] Make `dired-do-open' work on non GNU/Linux systems Date: Thu, 05 Sep 2024 16:36:30 +0200 Message-ID: <871q1yw4k1.fsf@ledu-giraud.fr> References: <87le083m1s.fsf@ledu-giraud.fr> <877cbqjt03.fsf@posteo.net> <87h6auw6sj.fsf@ledu-giraud.fr> <86y1462o7u.fsf@gnu.org> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7922"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 73004@debbugs.gnu.org, philipk@posteo.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 05 16:37:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1smDbr-0001pd-3p for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Sep 2024 16:37:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smDbX-0000Ky-Tj; Thu, 05 Sep 2024 10:37:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smDbV-0000KF-Uh for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2024 10:36:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1smDbV-0004F7-Kv for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2024 10:36:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=wKF3cF8nTRor0DA/iWjYLVHA0g+OcZ2okHGa6KPRY+I=; b=LvFgOLcbg0HP15yRxdo5gX/4ECjKwWwjFlNyFP3ISIzwnZHK34Ffh9OXAuWgngyrzXjSN53UNrCilm8ga5Vx2cKoakakWY0jJo0vQgDsBXC+VxpcXth1QH1G6sqZmaQHtN23eVhwxNH6FAfetGXuqfyGkGdqvfnG6xI1cPm/tSXg6zmp/iicycGgu1isisVd/2lVaPvDIzn2c9KxJRbSkiFuenvax5vGig2luCK0/LX/yWG8xWIHbQF6DrEKbnKNIoqAlKtSvYgRx2KzkY8vRLcBFlv0t3agNdxj3uULZcuVHDh+NAHtcfjQnvLEkplZsb2QT/s4rg6xAgkejd9bGQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1smDcY-0006du-G1 for bug-gnu-emacs@gnu.org; Thu, 05 Sep 2024 10:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Sep 2024 14:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73004 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73004-submit@debbugs.gnu.org id=B73004.172554706025429 (code B ref 73004); Thu, 05 Sep 2024 14:38:02 +0000 Original-Received: (at 73004) by debbugs.gnu.org; 5 Sep 2024 14:37:40 +0000 Original-Received: from localhost ([127.0.0.1]:37768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smDcC-0006c4-CE for submit@debbugs.gnu.org; Thu, 05 Sep 2024 10:37:40 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:2803) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smDc9-0006bu-KM for 73004@debbugs.gnu.org; Thu, 05 Sep 2024 10:37:38 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=rLAfIYBx 8FcgEWp9QZ229FJ1eGxdvsgG1duwdmTQLoM=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=/zg002Xtwbd2ZcH2cJTShF0zXD80zG RJr04Qk4B1zdW+MOF9w6Lpgu5MD+qe1eH8lLrMgDoOdC6nVjFPC+uHBg== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=rLAfIYBx8FcgEWp9 QZ229FJ1eGxdvsgG1duwdmTQLoM=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=XytqWA2eKSdq8LXFvYH5FwqRIS88SHy3zvK/Fa 0n3Ho8+wwMDXG15+tvL+jj60yGhW4h872pubJ74+Q1bigQ6q5O1QMuD28feceSzN6AMwm9 LIPPKOhuHjIGEE1FZ4wFNKoo77KD3JOvmbLvNo36dSO85/LlVB0rxrtnODZtimmEWWRkaW SACFIdC7X2hBj/xTO6gWnR/VNeqAQrraZVGb66wDoS0SiX3+mZ8cFmjd/uLD/wmZKwKQYa CiwA1NWHG7UQ94RIRsmGLFJesp4XKWTnV2tVrh+lz4X8CPAEla+19XtcUqRInzYtzJYS+e ZR5Lu40JlSjjVdsWrkDUlaeg== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 9c298c42 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 5 Sep 2024 16:36:30 +0200 (CEST) In-Reply-To: <86y1462o7u.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 05 Sep 2024 17:02:13 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291259 Archived-At: Eli Zaretskii writes: >> Cc: 73004@debbugs.gnu.org >> Date: Thu, 05 Sep 2024 15:48:12 +0200 >> From: Manuel Giraud via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> > And is xdg-open reliably available on BSD systems, so that we don't >> > generate an opaque error message if that is not the case? >> >> I think it would work whether xdg-open is install or not because >> `shell-command-guess-open' is defined by testing the presence of >> xdg-open. So if xdg-open is not installed, `command' in the code above >> will be nil and nothing will happen. > > Then why do we need to condition this by system-type at all? Yes I wondered this too. The current "otherwise" clause is an error message but it could be this `call-process' instead. -- Manuel Giraud