all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Sean Whitton <spwhitton@spwhitton.name>
To: Eli Zaretskii <eliz@gnu.org>, philipk@posteo.net
Cc: 69097@debbugs.gnu.org, acorallo@gnu.org, stefankangas@gmail.com,
	rms@gnu.org, juri@linkov.net
Subject: bug#69097: [PATCH] Add 'kill-region-or-word' command
Date: Sat, 07 Sep 2024 22:08:17 +0100	[thread overview]
Message-ID: <871q1vuq7y.fsf@zephyr.silentflame.com> (raw)
In-Reply-To: <86frqbyemw.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 07 Sep 2024 12:52:39 +0300")

[-- Attachment #1: Type: text/plain, Size: 729 bytes --]

Hello,

Thank you both for the feedback.  Attached is an updated version.

A few replies:

On Fri 06 Sep 2024 at 04:32pm GMT, Philip Kaludercic wrote:

> Won't there be an error here if the command is invoked with a negative
> argument?

Do you mean that you think there should be an error?
I don't see any need for that.

On Sat 07 Sep 2024 at 12:52pm +03, Eli Zaretskii wrote:

> I again ask whether we need this command.  It is okay to have a
> function (perhaps even an internal one) to move by Unix-words, but
> what are the use cases for such a command?

That's fine.  I've turned it back into a function.

> Should we also treat a backslash as delimiter, for MS-Windows?

Good idea.  That's more useful.

-- 
Sean Whitton

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: v3-0001-New-commands-for-moving-and-killing-unix-words.patch --]
[-- Type: text/x-patch, Size: 3992 bytes --]

From 9163f6ab16816702f8bc6acb6f22734eb57acfc7 Mon Sep 17 00:00:00 2001
From: Sean Whitton <spwhitton@spwhitton.name>
Date: Fri, 6 Sep 2024 11:35:46 +0100
Subject: [PATCH v3] New commands for moving and killing unix-words

* lisp/simple.el (forward-unix-word): New function.
(unix-word-rubout, unix-filename-rubout): New commands.
* etc/NEWS: Announce the new commands.
---
 etc/NEWS       |  6 ++++++
 lisp/simple.el | 57 ++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 63 insertions(+)

diff --git a/etc/NEWS b/etc/NEWS
index f3e719a34d3..104941425c2 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -123,6 +123,12 @@ When using 'visual-wrap-prefix-mode' in buffers with variable-pitch
 fonts, the wrapped text will now be lined up correctly so that it's
 exactly below the text after the prefix on the first line.
 
+---
+** New commands 'unix-word-rubout' and 'unix-filename-rubout'.
+Unix-words are words separated by whitespace regardless of the buffer's
+syntax table.  In a Unix terminal or shell, C-w kills by Unix-word.
+The new commands 'unix-word-rubout' and 'unix-filename-rubout' allow
+you to bind keys to operate more similarly to the terminal.
 \f
 * Changes in Specialized Modes and Packages in Emacs 31.1
 
diff --git a/lisp/simple.el b/lisp/simple.el
index 2453a129d0a..1b910b0ed22 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -8892,6 +8892,63 @@ current-word
       ;; If we found something nonempty, return it as a string.
       (unless (= start end)
 	(buffer-substring-no-properties start end)))))
+
+(defun forward-unix-word (n &optional delim)
+  "Move forward N Unix-words.
+A Unix-word is whitespace-delimited.
+A negative N means go backwards to the beginning of Unix-words.
+
+Unix-words differ from Emacs words in that they are always delimited by
+whitespace, regardless of the buffer's syntax table.  This function
+emulates how C-w at the Unix terminal or shell identifies words.
+
+Optional argument DELIM specifies what characters are considered
+whitespace.  It is a string as might be passed to `skip-chars-forward'.
+The default is \"\\s\\f\\n\\r\\t\\v\".  Do not prefix a `^' character."
+  (when (and delim (string-prefix-p "^" delim))
+    (error "DELIM argument must not begin with `^'"))
+  (unless (zerop n)
+    ;; We do skip over newlines by default because `backward-word' does.
+    (let* ((delim (or delim "\s\f\n\r\t\v"))
+           (ndelim (format "^%s" delim))
+           (start (point))
+           (fun (if (> n 0)
+                    #'skip-chars-forward
+                  #'skip-chars-backward)))
+      (dotimes (_ (abs n))
+        (funcall fun delim)
+        (funcall fun ndelim))
+      (constrain-to-field nil start))))
+
+(defun unix-word-rubout (arg)
+  "Kill ARG Unix-words backwards.
+A Unix-word is whitespace-delimited.
+Interactively, ARG is the numeric prefix argument, defaulting to 1.
+A negative ARG means to kill forwards.
+
+Unix-words differ from Emacs words in that they are always delimited by
+whitespace, regardless of the buffer's syntax table.
+Thus, this command emulates C-w at the Unix terminal or shell.
+See also this command's nakesake in Info node
+`(readline)Commands For Killing'."
+  (interactive "^p")
+  (let ((start (point)))
+    (forward-unix-word (- arg))
+    (kill-region start (point))))
+
+(defun unix-filename-rubout (arg)
+  "Kill ARG Unix-words backwards, also treating `/' as delimiting words.
+A Unix-word is whitespace-delimited.
+Interactively, ARG is the numeric prefix argument, defaulting to 1.
+A negative ARG means to kill forwards.
+
+This is like `unix-word-rubout' (which see), but `/' is also treated as
+a word delimiter.  See this command's namesake in Info node
+`(readline)Commands For Killing'."
+  (interactive "^p")
+  (let ((start (point)))
+    (forward-unix-word (- arg) "\\/\s\f\n\r\t\v")
+    (kill-region start (point))))
 \f
 (defcustom fill-prefix nil
   "String for filling to insert at front of new line, or nil for none."
-- 
2.39.2


  parent reply	other threads:[~2024-09-07 21:08 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-13  9:55 bug#69097: [PATCH] Add 'kill-region-or-word' command Philip Kaludercic
2024-02-17  3:53 ` Richard Stallman
     [not found]   ` <87ttm7gi9i.fsf@posteo.net>
2024-02-19  3:44     ` Richard Stallman
     [not found]       ` <87sf1obkw9.fsf@posteo.net>
2024-02-23  3:04         ` Richard Stallman
     [not found]           ` <871q93rzv8.fsf@posteo.net>
2024-02-25  3:16             ` Richard Stallman
     [not found]               ` <87frxgn73g.fsf@posteo.net>
2024-02-27  3:12                 ` Richard Stallman
2024-05-03  7:37 ` Philip Kaludercic
2024-05-03 10:40   ` Eli Zaretskii
2024-05-03 10:48     ` Philip Kaludercic
2024-05-03 10:59       ` Eli Zaretskii
2024-05-03 11:04         ` Eli Zaretskii
2024-05-03 17:32           ` Philip Kaludercic
2024-05-03 18:01             ` Eli Zaretskii
2024-05-03 19:41               ` Philip Kaludercic
2024-05-04  6:20                 ` Eli Zaretskii
2024-05-05  6:53                 ` Juri Linkov
2024-05-05  9:04                   ` Eli Zaretskii
2024-05-05 16:29                     ` Juri Linkov
2024-05-05 16:54                       ` Philip Kaludercic
2024-05-05 16:59                         ` Juri Linkov
2024-05-05 17:08                           ` Drew Adams via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-05 18:27                           ` Philip Kaludercic
2024-05-05 17:05                         ` Drew Adams via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-05 17:13                           ` Eli Zaretskii
2024-05-05 17:53                             ` Drew Adams via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-06  0:21                       ` Sean Whitton via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-06 16:46                     ` Sean Whitton via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-06 16:51                       ` Sean Whitton via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-06 17:55                         ` Eli Zaretskii
2024-05-07  8:47                           ` Sean Whitton via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-07  8:47                             ` Sean Whitton via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-01 20:06                           ` Philip Kaludercic
2024-09-02  6:36                             ` Sean Whitton
2024-09-02 11:18                             ` Eli Zaretskii
2024-09-02 18:30                               ` Stefan Kangas
2024-09-02 18:45                                 ` Sean Whitton
2024-09-02 20:39                               ` Philip Kaludercic
2024-09-02 20:42                                 ` Sean Whitton
2024-09-02 20:45                                   ` Philip Kaludercic
2024-09-02 20:46                                   ` Sean Whitton
2024-09-02 21:12                                     ` Philip Kaludercic
2024-09-03 12:21                                       ` Eli Zaretskii
2024-09-03 13:53                                         ` Robert Pluim
2024-09-03 14:27                                           ` Eli Zaretskii
2024-09-03 14:55                                             ` Robert Pluim
2024-09-03 15:32                                               ` Eli Zaretskii
2024-09-03 16:32                                         ` Philip Kaludercic
2024-09-03 16:47                                           ` Robert Pluim
2024-09-04 11:08                                           ` Eli Zaretskii
2024-09-04 14:07                                           ` Sean Whitton
2024-09-04 14:21                                             ` Eli Zaretskii
2024-09-05  9:39                                             ` Philip Kaludercic
2024-09-05  9:52                                               ` Eli Zaretskii
2024-09-05 10:02                                                 ` Philip Kaludercic
2024-09-05 10:19                                                   ` Eli Zaretskii
2024-09-05 10:23                                                     ` Philip Kaludercic
2024-09-05 13:27                                               ` Sean Whitton
2024-09-05 14:38                                                 ` Philip Kaludercic
2024-09-06 10:36                                                   ` Sean Whitton
2024-09-06 11:06                                                     ` Sean Whitton
2024-09-06 11:30                                                     ` Eli Zaretskii
2024-09-06 13:54                                                       ` Sean Whitton
2024-09-06 16:32                                                         ` Philip Kaludercic
2024-09-07  9:52                                                         ` Eli Zaretskii
2024-09-07 10:10                                                           ` Philip Kaludercic
2024-09-07 21:08                                                           ` Sean Whitton [this message]
2024-09-07 21:17                                                             ` Sean Whitton
2024-09-09 17:54                                                               ` Sean Whitton
2024-09-09 19:03                                                                 ` Eli Zaretskii
2024-09-09 19:48                                                                   ` Sean Whitton
2024-09-09 19:23                                                                 ` Philip Kaludercic
2024-09-14  9:12                                                                   ` Eli Zaretskii
2024-09-14 11:27                                                                     ` Sean Whitton
2024-09-14 13:39                                                                       ` Philip Kaludercic
2024-09-14 14:05                                                                         ` Eli Zaretskii
2024-09-14 14:13                                                                           ` Philip Kaludercic
2024-09-14 14:24                                                                             ` Eli Zaretskii
2024-09-14 16:10                                                                             ` Sean Whitton
2024-09-14 16:26                                                                               ` German Pacenza
2024-09-14 16:36                                                                                 ` Sean Whitton
2024-09-14 21:19                                                                               ` Philip Kaludercic
2024-09-14 21:22                                                                                 ` Sean Whitton
2024-09-17 17:58                                                                             ` Juri Linkov
2024-09-18 16:08                                                                               ` Juri Linkov
2024-09-19  7:19                                                                               ` Philip Kaludercic
2024-09-08 10:38                                                             ` Philip Kaludercic
2024-05-05 16:47                   ` Drew Adams via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-03 16:20         ` Philip Kaludercic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871q1vuq7y.fsf@zephyr.silentflame.com \
    --to=spwhitton@spwhitton.name \
    --cc=69097@debbugs.gnu.org \
    --cc=acorallo@gnu.org \
    --cc=eliz@gnu.org \
    --cc=juri@linkov.net \
    --cc=philipk@posteo.net \
    --cc=rms@gnu.org \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.