From: Philip Kaludercic <philipk@posteo.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: suhailsingh247@gmail.com, meedstrom@runbox.eu,
emacs-devel@gnu.org, tonyzorman@mailbox.org
Subject: Re: Reconsider defaults for use-package-vc-prefer-newest
Date: Sat, 21 Sep 2024 15:43:58 +0000 [thread overview]
Message-ID: <871q1dm2pt.fsf@posteo.net> (raw)
In-Reply-To: <86plox2fxo.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 21 Sep 2024 18:18:43 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Philip Kaludercic <philipk@posteo.net>
>> Cc: suhailsingh247@gmail.com, meedstrom@runbox.eu, emacs-devel@gnu.org,
>> tonyzorman@mailbox.org
>> Date: Sat, 21 Sep 2024 14:31:21 +0000
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>> >> From: Philip Kaludercic <philipk@posteo.net>
>> >> Cc: suhailsingh247@gmail.com, meedstrom@runbox.eu, emacs-devel@gnu.org,
>> >> tonyzorman@mailbox.org
>> >> Date: Fri, 20 Sep 2024 20:43:27 +0000
>> >>
>> >> Eli Zaretskii <eliz@gnu.org> writes:
>> >>
>> >> >> From: Philip Kaludercic <philipk@posteo.net>
>> >> >> Cc: suhailsingh247@gmail.com, meedstrom@runbox.eu, emacs-devel@gnu.org,
>> >> >> tonyzorman@mailbox.org
>> >> >> Date: Fri, 20 Sep 2024 15:14:26 +0000
>> >> >>
>> >> >> Eli Zaretskii <eliz@gnu.org> writes:
>> >> >>
>> >> >> >> This is the fix:
>> >> >> >
>> >> >> > Can you explain in plain English what this does?
>> >> >>
>> >> >> Sure, each package has a description object (search for "(cl-defstruct
>> >> >> (package-desc" in package.el), with some fixed attributes like name,
>> >> >> version, dependencies and others that are stored in an alist. The
>> >> >> commit used to create a package is one such attribute stored in the
>> >> >> "extras" slot of a package-desc. My chance modifies the package
>> >> >> description given by the ELPA server and updates the :commit field to
>> >> >> store the commit that was checked out when the package was built
>> >> >> locally. I hope that is clear enough?
>> >> >
>> >> > Yes, thanks. What was the :commit field storing before the change?
>> >>
>> >> The commit the ELPA build server used to release a new version of the
>> >> package.
>> >
>> > That is not right, I agree.
>> >
>> >> M-x list-packages lists the commit of the local checkout for
>> >> VC packages, btw.
>> >
>> > What is "the local checkout" in this context?
>>
>> The checkout of the VC package that the *Help* buffer is describing.
>>
>> >> I could have sworn that M-x describe-package did the same.
>> >
>> > Shouldn't they all be consistent in what commit they show?
>>
>> Yes, that is my point. But since the commit in the package description
>> is not updated when the package is installed, there is a discrepancy.
>
> So your change should make all of them agree? In that case, please
> install, and thanks.
Right, will do.
--
Philip Kaludercic on siskin
next prev parent reply other threads:[~2024-09-21 15:43 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-14 12:09 Reconsider defaults for use-package-vc-prefer-newest Martin Edström
2024-09-19 11:49 ` Philip Kaludercic
2024-09-19 18:50 ` Suhail Singh
2024-09-19 20:11 ` Philip Kaludercic
2024-09-19 20:31 ` Philip Kaludercic
2024-09-20 6:15 ` Eli Zaretskii
2024-09-20 15:14 ` Philip Kaludercic
2024-09-20 15:45 ` Eli Zaretskii
2024-09-20 16:56 ` Philip Kaludercic
2024-09-20 17:37 ` Eli Zaretskii
2024-09-20 20:43 ` Philip Kaludercic
2024-09-21 7:14 ` Eli Zaretskii
2024-09-21 14:31 ` Philip Kaludercic
2024-09-21 15:18 ` Eli Zaretskii
2024-09-21 15:43 ` Philip Kaludercic [this message]
2024-09-19 21:02 ` Suhail Singh
2024-09-20 20:34 ` Philip Kaludercic
2024-09-20 23:38 ` Suhail Singh
2024-09-21 7:06 ` chad
2024-09-21 14:27 ` Suhail Singh
2024-09-21 15:59 ` Philip Kaludercic
2024-09-21 19:04 ` Suhail Singh
2024-09-22 15:30 ` Philip Kaludercic
2024-09-22 20:08 ` Suhail Singh
2024-09-25 12:06 ` Suhail Singh
2024-09-25 13:15 ` Philip Kaludercic
2024-09-25 12:07 ` Philip Kaludercic
2024-09-25 15:15 ` Suhail Singh
2024-09-25 20:11 ` Philip Kaludercic
2024-09-25 20:48 ` Suhail Singh
2024-09-29 2:13 ` Richard Stallman
2024-09-29 7:25 ` Philip Kaludercic
2024-09-29 13:55 ` Suhail Singh
2024-09-26 23:23 ` Charles Choi
2024-09-27 0:17 ` Adam Porter
2024-09-27 0:33 ` Suhail Singh
2024-09-27 6:46 ` Eli Zaretskii
2024-09-29 14:22 ` Stefan Kangas
2024-09-29 14:35 ` Eli Zaretskii
2024-10-11 18:54 ` Suhail Singh
2024-10-12 5:46 ` Eli Zaretskii
2024-09-20 4:57 ` Tony Zorman
2024-09-20 19:37 ` Martin Edström
2024-09-20 21:05 ` Philip Kaludercic
2024-09-21 14:44 ` Philip Kaludercic
2024-09-21 14:58 ` Tony Zorman
2024-09-21 15:10 ` Suhail Singh
2024-09-21 16:09 ` Philip Kaludercic
-- strict thread matches above, loose matches on Subject: below --
2024-09-15 17:38 Martin Edström
2024-09-15 18:24 ` Eli Zaretskii
2024-09-15 19:46 ` Martin Edstrom
2024-09-16 11:34 ` Eli Zaretskii
2024-09-16 15:24 ` Martin Edström
2024-09-16 16:15 ` Martin Edström
2024-09-16 17:57 ` Eli Zaretskii
2024-09-18 14:30 ` Martin Edström
2024-09-15 19:52 Martin Edström
2024-09-15 20:41 ` chad
2024-09-15 21:09 ` Martin Edstrom
2024-09-15 22:12 ` chad
2024-09-15 23:51 ` Martin Edstrom
2024-09-16 11:50 ` Eli Zaretskii
2024-09-16 16:46 ` Martin Edström
2024-09-16 18:10 ` Eli Zaretskii
2024-09-16 20:16 ` Suhail Singh
2024-09-17 11:44 ` Eli Zaretskii
2024-09-19 3:38 ` Suhail Singh
2024-09-19 6:28 ` Eli Zaretskii
2024-09-19 12:08 ` Suhail Singh
2024-09-19 12:39 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871q1dm2pt.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=meedstrom@runbox.eu \
--cc=suhailsingh247@gmail.com \
--cc=tonyzorman@mailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.