From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sam James Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] configure.ac: Fix FIONREAD check to work with gcc-14 on Solaris Date: Wed, 23 Oct 2024 19:10:05 +0100 Organization: Gentoo Message-ID: <871q063d36.fsf@gentoo.org> References: <20241008210227.27362-2-alan.coopersmith@oracle.com> <865xpxwg3a.fsf@gnu.org> <87fromrhpa.fsf@gentoo.org> <86a5euembw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37967"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefankangas@gmail.com, alan.coopersmith@oracle.com, emacs-devel@gnu.org, Ali.Bahrami@oracle.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 23 20:11:20 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t3fpG-0009jj-VG for ged-emacs-devel@m.gmane-mx.org; Wed, 23 Oct 2024 20:11:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t3foI-000668-MF; Wed, 23 Oct 2024 14:10:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t3foD-00064G-Vb for emacs-devel@gnu.org; Wed, 23 Oct 2024 14:10:13 -0400 Original-Received: from woodpecker.gentoo.org ([140.211.166.183] helo=smtp.gentoo.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1t3foB-0005Nh-CA; Wed, 23 Oct 2024 14:10:12 -0400 In-Reply-To: <86a5euembw.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 23 Oct 2024 20:54:59 +0300") Received-SPF: pass client-ip=140.211.166.183; envelope-from=sam@gentoo.org; helo=smtp.gentoo.org X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324800 Archived-At: Eli Zaretskii writes: >> From: Sam James >> Cc: Stefan Kangas , alan.coopersmith@oracle.com, >> emacs-devel@gnu.org, Ali.Bahrami@oracle.com >> Date: Wed, 23 Oct 2024 15:56:33 +0100 >> >> >> I guess this should be installed on emacs-30. Eli, WDYT? >> > >> > I'd prefer on master. Who knows what addition of unistd.h could cause >> > to this test? >> >> Note that the absence of the include means the configure check gives the >> wrong result, it doesn't mean Emacs necessarily fails to build as a >> result. It may be built with the wrong configuration. > > I understand. But Solaris isn't a very important platform for us to > risk screwing other platforms, when we are quite close to a release, > and people who want to build Emacs 30 on Solaris can always apply this > change by hand. OK, fair enough.