From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alp Aker Newsgroups: gmane.emacs.devel Subject: Re: Fill column indicator functionality Date: Fri, 15 Mar 2019 10:35:41 -0400 Message-ID: <870b0500-a2ff-88e2-f6b4-15763ff5065c@gmail.com> References: <20190309132207.w2ho3j6p5on6fyzw@Ergus> <838sxo87gc.fsf@gnu.org> <20190311104814.kp2nv6arv47hcykz@Ergus> <83y35l4ee0.fsf@gnu.org> <20190312152928.73o4b5fk4paz7wm5@Ergus> <834l883w15.fsf@gnu.org> <20190312192017.fkfd4h5gsbdue5q3@Ergus> <83imwm3fxf.fsf@gnu.org> <20190313200225.dpqrw7xthkj47fqw@Ergus> <83bm2e35a1.fsf@gnu.org> <20190314030224.l5zseslncw3xc5ox@Ergus> <835zsm2c2s.fsf@gnu.org> <303612d8-e691-f753-84c9-f462d88262b6@gmail.com> <83d0ms1to4.fsf@gnu.org> <83zhpwz1i6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="187888"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 15 16:02:17 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h4oLh-000mlx-BV for ged-emacs-devel@m.gmane.org; Fri, 15 Mar 2019 16:02:17 +0100 Original-Received: from localhost ([127.0.0.1]:56910 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4oLg-0000X5-Bu for ged-emacs-devel@m.gmane.org; Fri, 15 Mar 2019 11:02:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50554) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h4o1A-0008Na-DL for emacs-devel@gnu.org; Fri, 15 Mar 2019 10:41:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h4nxH-00069Q-Mp for emacs-devel@gnu.org; Fri, 15 Mar 2019 10:37:05 -0400 Original-Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741]:35884) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h4nxG-00068I-Pj; Fri, 15 Mar 2019 10:37:03 -0400 Original-Received: by mail-qk1-x741.google.com with SMTP id k130so5622233qke.3; Fri, 15 Mar 2019 07:37:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=CEgR+TSM7q5KpbyTIGVqSZWTqdZR8u3EHtLpf14hOlw=; b=M4S+PCKxicQcjAbfnQGTx7IDRqyAW3k1XpH/i9qIZ1WQTx5A6r7YurevmwLNBw2Lfv PuCGXoYdzaVyNsZ7qISF5J+OWVo5HiSuo7MDR8YZJLK98Qn68ubAqb6qdb5fA6xR+BMQ OaF05vRtKNTA7291I+0JYpuuisxcH1xY9KF0o0Utv521Ph8oJeNnnAbAALatm/Zq0M6a UKU0cdRGnlaP/YXACaRNeT1ftD9u+mjiAKQYewp4hstQIdRJBMpGECJLR7Pe1CGPHHkE zcnH5Cdvl4ZTKi0bIG0hK0acGpnfHTEbDKDs4czSkGMJiZzxtfHPHhGdZBqDJEDAjP+w lfOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=CEgR+TSM7q5KpbyTIGVqSZWTqdZR8u3EHtLpf14hOlw=; b=nTvG4yLfEbiCZdYBKTpYB1m3ZPCAa6uP47F63ynYoRWSp2Hp7f1iTGMSYvxdGv8ytP YL14aR+KYdT0b0bBxd9NeXT5YPyCgQI6FwsNe4F4kAd3Eb1cMpXydbyzQBSVUUjQAo4R ks3X+j3RZN8MoLI8bQ8xxbGYZUdV2ywWm44X9PzEUJmWvLjUxTQ5Z02NlMeEKYJud09/ 5krShsbxXEXCVhkMuAvXe2UgQrTvqsFHl0PdCwE/j1bnmEscCl/gZvd1YDff6W5Wr6I7 m3x4jXCW77JPEp8ysI2oAlC1kINYD2tiucEez9M/+On9mUO4/P1bwL2n7W6QjeTj5BEE ZJjQ== X-Gm-Message-State: APjAAAW3nMDkzrmw4zTBYu5HQ3SSBv8nPciGqu5PI/mdzIunTiBNd0jq xsdMS6pfqr21zOlcpMp/E8BjpTUb X-Google-Smtp-Source: APXvYqw+zmGDAcKL60UZKwS8x+vJVlqkmIwxkw8S4H6X/oFuAGpGxhjHEG7z+zsNvkxi9x7yAPtTrA== X-Received: by 2002:a37:a8cb:: with SMTP id r194mr2925515qke.53.1552660619956; Fri, 15 Mar 2019 07:36:59 -0700 (PDT) Original-Received: from [10.0.1.6] (cpe-98-14-239-39.nyc.res.rr.com. [98.14.239.39]) by smtp.gmail.com with ESMTPSA id j128sm386104qkd.27.2019.03.15.07.36.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Mar 2019 07:36:58 -0700 (PDT) In-Reply-To: <83zhpwz1i6.fsf@gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::741 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234163 Archived-At: > I'm sure users will find customizing a character much easier than > customizing an image. In any case, I wouldn't give up on allowing a > character, even if we do support images, because there's no reason to > restrict users to images. For example, a suitable selection of a > character could produce identical displays on GUI and TTY frames, > something that an image could never do. I just wanted to expand on this point and clarify my motivations for chiming in on this discussion.  I'm very grateful Ergus is doing this work, as I've long felt that the functionality of fill-column-indicator can only be robustly implemented in the display engine.  I merely want to offer my experience as the author of what, until now, has been the main package providing this kind of functionality in order to make Ergus's work more successful. When I first implemented fill-column-indicator I used a character-based approach and, overwhelmingly, the feedback I received from users concerned difficulties in finding and successfully configuring use of a font that would provide a seamless visual effect.  When I added the option to use XPM images (generated not by the user, but by the package, with customization options concerning color, thickness, etc.), users only seemed to make use of that.  I've never received a complaint from someone wanting to use the package on a system that didn't support XPM images. > >>> . Using the continuous line would cause complications wrt redisplay >>> optimizations. Redisplay of text is highly optimized in Emacs, and >>> frequently needs to update only a small portion of the window. The >>> problem is what to do about the indicator line when only some >>> portions are redrawn. >> Unless I'm mistaken, the method I'm describing would allow the same >> optimizations > Yes, but I was replying to a completely different idea. What you > propose is just a trivial extension of the code posted here, so all of > the effort that went into that will still be valid, and most of my > message is not really relevant.