From: Dmitry Gutov <dgutov@yandex.ru>
To: Kevin Brubeck Unhammer <unhammer@fsfe.org>
Cc: 18788@debbugs.gnu.org
Subject: bug#18788: 24.4; vc-git-working-revision vs mode-line gives error
Date: Sun, 14 Dec 2014 13:15:18 +0200 [thread overview]
Message-ID: <86zjaqo52x.fsf@yandex.ru> (raw)
In-Reply-To: <87wq7sfqtt.fsf@fsfe.org> (Kevin Brubeck Unhammer's message of "Wed, 22 Oct 2014 10:31:42 +0200")
Kevin Brubeck Unhammer <unhammer@fsfe.org> writes:
> Whenever I try to save a git-registered file under emacs 24.4, I get
>
> apply: Args out of range: #("Git@" 0 4 (help-echo "Locally added
> file under the Git version control system")), 0, 7
I don't see that.
Does that happen in a bare session (started with `emacs -Q')?
Is there anything special about the repository, or its current local state?
> The function vc-git-mode-line-string tries to get the revision using
> vc-working-revision, which returns nil. Instead of checking the `rev'
> variable for nil, it checks `detached', before calling substring. It
> should probably do
>
> (if (and detached rev)
> (substring …)
> …)
>
> instead. I don't know why vc-working-revision returns nil though
> (there's a whole lot of indirection to dig through there).
Does (vc-git-working-revision buffer-file-name) return nil in the same buffer?
next prev parent reply other threads:[~2014-12-14 11:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 8:31 bug#18788: 24.4; vc-git-working-revision vs mode-line gives error Kevin Brubeck Unhammer
2014-12-14 11:15 ` Dmitry Gutov [this message]
2014-12-15 9:50 ` Kevin Brubeck Unhammer
2015-01-31 13:09 ` Kevin Brubeck Unhammer
2015-02-02 13:10 ` Dmitry Gutov
2015-02-02 13:53 ` Kevin Brubeck Unhammer
2015-12-26 16:22 ` Lars Ingebrigtsen
2015-12-27 8:15 ` Kevin Brubeck Unhammer
2015-02-11 6:08 ` nil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86zjaqo52x.fsf@yandex.ru \
--to=dgutov@yandex.ru \
--cc=18788@debbugs.gnu.org \
--cc=unhammer@fsfe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.