FreeBSD configure error related to liblockfile

FreeBSD configure error related to liblockfile

[Joseph Mingrone]

[-- Attachment #1: Type: text/plain, Size: 928 bytes --]

Hi,

Configure error:
- liblockfile package installed and `configure --without-x`

checking for maillock in -lmail... no
checking for maillock in -llockfile... no
checking for liblockfile.so... yes
configure: error: Shared liblockfile found but can't link against it.
This probably means that movemail could lose mail.
There may be a 'development' package to install containing liblockfile.

No configure error:
- liblockfile package not installed
- liblockfile package installed and `configure` (no arguments)
- liblockfile and GNU mailutils packages installed

What do you recommend for the package?

1. We could just add ac_cv_prog_liblockfile=no to the configure environment.
2. We could add a dependency on GNU mailutils.
3. We could add an option to depend on GNU mailutils.  If that option is turned off, then add ac_cv_prog_liblockfile=no to the configure environment.
4. Another approach I am missing.

Thanks,

Joseph

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

Re: FreeBSD configure error related to liblockfile

[Robert Pluim]

Joseph Mingrone <jrm@ftfl.ca> writes:

> Hi,
>
> Configure error:
> - liblockfile package installed and `configure --without-x`
>
> checking for maillock in -lmail... no
> checking for maillock in -llockfile... no
> checking for liblockfile.so... yes
> configure: error: Shared liblockfile found but can't link against it.
> This probably means that movemail could lose mail.
> There may be a 'development' package to install containing liblockfile.
>

Could you show us the config.log corresponding to this error? And tell
us which version of Emacs you're building?

> No configure error:
> - liblockfile package not installed
> - liblockfile package installed and `configure` (no arguments)
> - liblockfile and GNU mailutils packages installed
>
> What do you recommend for the package?
>
> 1. We could just add ac_cv_prog_liblockfile=no to the configure environment.
> 2. We could add a dependency on GNU mailutils.
> 3. We could add an option to depend on GNU mailutils.  If that option is turned off, then add ac_cv_prog_liblockfile=no to the configure environment.
> 4. Another approach I am missing.

The fact that this happens only when using '--without-x' indicates to
me that there might be a bug in our configure script which we should
attempt to fix.

Robert

Re: FreeBSD configure error related to liblockfile

[Joseph Mingrone]

[-- Attachment #1: Type: text/plain, Size: 2498 bytes --]

Robert Pluim <rpluim@gmail.com> writes:

> Joseph Mingrone <jrm@ftfl.ca> writes:

>> Hi,

>> Configure error:
>> - liblockfile package installed and `configure --without-x`

>> checking for maillock in -lmail... no
>> checking for maillock in -llockfile... no
>> checking for liblockfile.so... yes
>> configure: error: Shared liblockfile found but can't link against it.
>> This probably means that movemail could lose mail.
>> There may be a 'development' package to install containing liblockfile.


> Could you show us the config.log corresponding to this error? And tell
> us which version of Emacs you're building?

>> No configure error:
>> - liblockfile package not installed
>> - liblockfile package installed and `configure` (no arguments)
>> - liblockfile and GNU mailutils packages installed

>> What do you recommend for the package?

>> 1. We could just add ac_cv_prog_liblockfile=no to the configure environment.
>> 2. We could add a dependency on GNU mailutils.
>> 3. We could add an option to depend on GNU mailutils.  If that option is turned off, then add ac_cv_prog_liblockfile=no to the configure environment.
>> 4. Another approach I am missing.

> The fact that this happens only when using '--without-x' indicates to
> me that there might be a bug in our configure script which we should
> attempt to fix.

> Robert

This is with version 25.3 and with a recent commit from the master branch.

Here is the config.log (liblockfile installed and --without-x).
https://ftfl.ca/misc/emacs_nox_error_liblockfile.log

Here is the config.log for a successful configure (liblockfile installed)
https://ftfl.ca/misc/emacs_config.log

These are the files included in the liblockfile package.

# pkg info -l liblockfile
liblockfile-1.14:
        /usr/local/bin/dotlockfile
        /usr/local/include/lockfile.h
        /usr/local/include/maillock.h
        /usr/local/lib/liblockfile.a
        /usr/local/lib/liblockfile.so
        /usr/local/lib/liblockfile.so.1
        /usr/local/lib/liblockfile.so.1.0
        /usr/local/man/man1/dotlockfile.1.gz
        /usr/local/man/man3/lockfile_create.3.gz
        /usr/local/man/man3/maillock.3.gz
        /usr/local/share/doc/liblockfile/Changelog
        /usr/local/share/doc/liblockfile/README
        /usr/local/share/licenses/liblockfile-1.14/GPLv2+
        /usr/local/share/licenses/liblockfile-1.14/LGPL21+
        /usr/local/share/licenses/liblockfile-1.14/LICENSE
        /usr/local/share/licenses/liblockfile-1.14/catalog.mk

Joseph

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

Re: FreeBSD configure error related to liblockfile

[Paul Eggert]

Joseph Mingrone wrote:
> 2. We could add a dependency on GNU mailutils.

That sounds like it's the easiest fix. These days GNU mailutils is recommended 
anyway, as Emacs's own movemail program retrieves POP3 email only via insecure 
channels.

Re: FreeBSD configure error related to liblockfile

[Joseph Mingrone]

[-- Attachment #1: Type: text/plain, Size: 771 bytes --]

Paul Eggert <eggert@cs.ucla.edu> writes:

> Joseph Mingrone wrote:
>> 2. We could add a dependency on GNU mailutils.

> That sounds like it's the easiest fix. These days GNU mailutils is recommended anyway, as Emacs's own movemail program retrieves POP3 email only via insecure channels.

Sounds good, I will add that dependency.  However, it looks like I was mistaken.  Also depending on mailutils does not fix the issue with liblockfile installed and supplying the --without-x argument to configure.  Should both mailutils and liblockfile be added as dependencies?

In any case, it still seems like there is a problem with the configure script.  Shouldn't it be finding the installed maillock.h and be able to link against the lockfile shared library?

Thanks,

Joseph

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

Re: FreeBSD configure error related to liblockfile

[Joseph Mingrone]

[-- Attachment #1: Type: text/plain, Size: 1561 bytes --]

Joseph Mingrone <jrm@ftfl.ca> writes:

> Paul Eggert <eggert@cs.ucla.edu> writes:

>> Joseph Mingrone wrote:
>>> 2. We could add a dependency on GNU mailutils.

>> That sounds like it's the easiest fix. These days GNU mailutils is recommended anyway, as Emacs's own movemail program retrieves POP3 email only via insecure channels.

> Sounds good, I will add that dependency.  However, it looks like I was mistaken.  Also depending on mailutils does not fix the issue with liblockfile installed and supplying the --without-x argument to
> configure.  Should both mailutils and liblockfile be added as dependencies?

> In any case, it still seems like there is a problem with the configure script.  Shouldn't it be finding the installed maillock.h and be able to link against the lockfile shared library?

> Thanks,

> Joseph

The liblockfile checks pass after adding LDFLAGS+=-L${LOCALBASE}/lib.
Based on bug #10313, this addition to LDFLAGS feels like the right
approach for the FreeBSD port/package.

The confusion about GNU Mailutils fixing the problem was due to the
differences between 25.3 and the master branch.  In the master branch,
the locking tests are wrapped in

if test ! "$with_mailutils"; then
...
fi

Given this, I assume functionality provided by liblockfile is duplicated
in mailutils.  I think a sensible approach for the port/package would be
to set ac_cv_prog_liblockfile=no and, as you suggest, (optionally)
depend on GNU Mailutils for users that require movemail and the other
functionality provided by Mailutils.

Thanks again,

Joseph

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]