From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Cecilio Pardo Newsgroups: gmane.emacs.bugs Subject: bug#38794: 26.1; Warnings in w32 build Date: Sun, 29 Dec 2019 17:04:41 +0100 Message-ID: <86zhfb86ee.fsf@inmotica-integral.es> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="57825"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (windows-nt) To: 38794@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 29 17:05:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ilb49-000Etb-Tv for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Dec 2019 17:05:18 +0100 Original-Received: from localhost ([::1]:53076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ilb48-0004L1-D6 for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Dec 2019 11:05:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52085) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ilb3x-0004Jv-Ex for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2019 11:05:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ilb3u-0006tW-SI for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2019 11:05:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54125) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ilb3u-0006sI-Iu for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2019 11:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ilb3u-0007jQ-EE for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2019 11:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Cecilio Pardo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Dec 2019 16:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 38794 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.157763549729705 (code B ref -1); Sun, 29 Dec 2019 16:05:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 29 Dec 2019 16:04:57 +0000 Original-Received: from localhost ([127.0.0.1]:60098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilb3p-0007j3-0i for submit@debbugs.gnu.org; Sun, 29 Dec 2019 11:04:57 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:35859) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ilb3n-0007it-27 for submit@debbugs.gnu.org; Sun, 29 Dec 2019 11:04:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51242) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ilb3j-0004FE-Az for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2019 11:04:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ilb3e-0006H1-As for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2019 11:04:50 -0500 Original-Received: from mout.kundenserver.de ([217.72.192.74]:38173) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ilb3d-00063G-U0 for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2019 11:04:46 -0500 Original-Received: from there ([79.151.178.40]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.158]) with ESMTPA (Nemesis) id 1MCsDe-1iuQlG1cIq-008qsd for ; Sun, 29 Dec 2019 17:04:42 +0100 X-Provags-ID: V03:K1:vggHv5gDlgYbQkffGtRt8x1U3UnBzOoylqITGhb5OcSx36bsJvH GVfKmtdBIQ8QHdncFMt55u13ofk2NImKGAUqTxD9ki1r9TWaWtkGi4FFs8cmXvLOBtZfqoj HvhwnM0/KiE0XYPYmDHHGvx3zddAKv9bQ5P+wsuKsR7cpeTnIdAhJ9YTSBAVKKp/jKZOlsR WSZl4MsoL+rlAbSdwPttA== X-UI-Out-Filterresults: notjunk:1;V03:K0:ZOrEiH92Lio=:hH5RLUqeLTplG0h41C82a1 5CM9zJ1bl8cfm9QO4oiopZrML0rkGUJYPkw6MZQSA3XN70Wd3B0en1B/swAM8u2Qnzb/UUJ5E Xu1XiwuC0szMz7s25bOrj626XomXYEputhvKDQFLvAVPtaVilLoqFwtehT+RPrGe7697/roLu Ry81901xK39iP59nGhhiLwbKq0BuewNC4nbJJYs2Z+pUc0RVKxi69iA8Y39ZQVawGOtlCn+D7 0lxbs3ABGns0Fy5pwbxa9tSAYUOjv8Jk0w585RYC8Jk6SHHKlfJ7Qmu26vWsJFyy2lFqsKna/ o3KpqHKGrqLTG69Y9S2dRorzlcZwiBpY8IVRKoeZgO7uozSGT0NTrbBzEoUJFL0nkfpX8oAHT 3e5F6IPqxJcPslHmev67iLAEJGUXsFsr4Ittw9xD3E6BnXiQ+XvKczZFznLWBgM5sOxou8GZq EbbBRDiLEdNyn0GU6WDJphI84Dc5H0z69YUNuTC7DZEPP353ff4dFboxEF4iXrOsGARVm4EZn utgKtADhQtFEIC9H3+kmFM8mRSjTg73oUam1cZ5viFY185C9rAM0B0pJ2lz8o3lZ1WicPrUpm RGhTdEb4cI4cAD6jTXz0JixLZ2u5HmuNlpTaoZBHC1togDch74icq+/CmQkvUx5N8HkrhaK5H cbzNpPSbdWoy1K9na1m78VM4QW1j6u9fpIr3+y97VAoFYTaUOTZZ6/XMpOLctIN4FdCmAQ+Im r5GX0s0bXGNj2aNuwxXevhITGHGPvq5G+a5brKHndpXW/RdRFDkhnVnlJu6oMntZtNjC26+x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173893 Archived-At: Severity: wishlist Tags: patch I am getting some warnings building with mingw64, using gcc 9.2.0. It complies about possible buffer overruns with sprintf. Maybe upgrade to snprintf? This is the warnings message: addpm.c: In function 'main': addpm.c:291:37: warning: '\bin\' directive writing 5 bytes into a region of size between 2 and 261 [-Wformat-overflow=] 291 | sprintf (full_emacs_path, "%s\\bin\\%s", emacs_path, prog_name); | ^~~~~~~ addpm.c:291:8: note: 'sprintf' output between 18 and 277 bytes into a destination of size 261 291 | sprintf (full_emacs_path, "%s\\bin\\%s", emacs_path, prog_name); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ diff --git a/nt/addpm.c b/nt/addpm.c index 3fd1b1bdc0..7da1fb5424 100644 --- a/nt/addpm.c +++ b/nt/addpm.c @@ -257,7 +257,7 @@ main (int argc, char *argv[]) char full_emacs_path[MAX_PATH + 1]; IPersistFile *lnk; strcat (start_folder, "\\Emacs.lnk"); - sprintf (full_emacs_path, "%s\\bin\\%s", emacs_path, prog_name); + snprintf (full_emacs_path, sizeof (full_emacs_path), "%s\\bin\\%s", emacs_path, prog_name); IShellLinkA_SetPath (shortcut, full_emacs_path); IShellLinkA_SetDescription (shortcut, "GNU Emacs"); result = IShellLinkA_QueryInterface (shortcut, &IID_IPersistFile, @@ -288,7 +288,7 @@ main (int argc, char *argv[]) char full_emacs_path[MAX_PATH + 1]; IPersistFile *lnk; strcat (start_folder, "\\Emacs.lnk"); - sprintf (full_emacs_path, "%s\\bin\\%s", emacs_path, prog_name); + snprintf (full_emacs_path, sizeof (full_emacs_path), "%s\\bin\\%s", emacs_path, prog_name); IShellLinkA_SetPath (shortcut, full_emacs_path); IShellLinkA_SetDescription (shortcut, "GNU Emacs"); result = IShellLinkA_QueryInterface (shortcut, &IID_IPersistFile, -- Cecilio Pardo