From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#52518: Log only vc-command-messages Date: Wed, 15 Dec 2021 19:31:07 +0200 Organization: LINKOV.NET Message-ID: <86zgp1zsf8.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4769"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) To: 52518@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 15 20:04:38 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mxZZu-00017j-3y for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Dec 2021 20:04:38 +0100 Original-Received: from localhost ([::1]:46774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mxZZs-00014m-56 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Dec 2021 14:04:36 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46246) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxY9L-0003Z1-QA for bug-gnu-emacs@gnu.org; Wed, 15 Dec 2021 12:33:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50280) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mxY9G-0006uJ-Dq for bug-gnu-emacs@gnu.org; Wed, 15 Dec 2021 12:33:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mxY9G-00046D-6Z for bug-gnu-emacs@gnu.org; Wed, 15 Dec 2021 12:33:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Dec 2021 17:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 52518 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.163958954315701 (code B ref -1); Wed, 15 Dec 2021 17:33:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Dec 2021 17:32:23 +0000 Original-Received: from localhost ([127.0.0.1]:33593 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxY8d-00045A-J5 for submit@debbugs.gnu.org; Wed, 15 Dec 2021 12:32:23 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:45544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mxY8c-000453-C0 for submit@debbugs.gnu.org; Wed, 15 Dec 2021 12:32:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxY8b-00024a-Bh for bug-gnu-emacs@gnu.org; Wed, 15 Dec 2021 12:32:22 -0500 Original-Received: from relay12.mail.gandi.net ([217.70.178.232]:59491) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxY8Y-0006pi-W0 for bug-gnu-emacs@gnu.org; Wed, 15 Dec 2021 12:32:20 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 594D8200007 for ; Wed, 15 Dec 2021 17:32:15 +0000 (UTC) Received-SPF: pass client-ip=217.70.178.232; envelope-from=juri@linkov.net; helo=relay12.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222436 Archived-At: --=-=-= Content-Type: text/plain Tags: patch It's useful to customize vc-command-messages to t to be able to inspect the performed vc commands in the *Messages* buffer. When something goes wrong, it's clearly visible what command caused the problem. But displaying such all vc commands in the echo area causes too much noise. Here is an option to not display such messages, only log in the *Messages* buffer: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=vc-command-messages-log.patch diff --git a/lisp/vc/vc-dispatcher.el b/lisp/vc/vc-dispatcher.el index 346974bdba..894ca060eb 100644 --- a/lisp/vc/vc-dispatcher.el +++ b/lisp/vc/vc-dispatcher.el @@ -127,8 +127,12 @@ vc-delete-logbuf-window :group 'vc) (defcustom vc-command-messages nil - "If non-nil, display run messages from back-end commands." - :type 'boolean + "If non-nil, log run messages from back-end commands. +If `log', messages are logged to the *Messages* buffer, but not displayed. +Other non-nil values also display run messages in the echo area." + :type '(choice (const :tag "No display and no log" nil) + (const :tag "Display and log messages" t) + (const :tag "Only log messages without displaying" log)) :group 'vc) (defcustom vc-suppress-confirm nil @@ -335,7 +339,9 @@ vc-do-command (apply #'start-file-process command (current-buffer) command squeezed)))) (when vc-command-messages - (let ((inhibit-message (eq (selected-window) (active-minibuffer-window)))) + (let ((inhibit-message + (or (eq vc-command-messages 'log) + (eq (selected-window) (active-minibuffer-window))))) (message "Running in background: %s" full-command))) ;; Get rid of the default message insertion, in case we don't ;; set a sentinel explicitly. @@ -345,11 +351,15 @@ vc-do-command (when vc-command-messages (vc-run-delayed (let ((message-truncate-lines t) - (inhibit-message (eq (selected-window) (active-minibuffer-window)))) + (inhibit-message + (or (eq vc-command-messages 'log) + (eq (selected-window) (active-minibuffer-window))))) (message "Done in background: %s" full-command))))) ;; Run synchronously (when vc-command-messages - (let ((inhibit-message (eq (selected-window) (active-minibuffer-window)))) + (let ((inhibit-message + (or (eq vc-command-messages 'log) + (eq (selected-window) (active-minibuffer-window))))) (message "Running in foreground: %s" full-command))) (let ((buffer-undo-list t)) (setq status (apply #'process-file command nil t nil squeezed))) @@ -364,7 +374,9 @@ vc-do-command (if (integerp status) (format "status %d" status) status) full-command)) (when vc-command-messages - (let ((inhibit-message (eq (selected-window) (active-minibuffer-window)))) + (let ((inhibit-message + (or (eq vc-command-messages 'log) + (eq (selected-window) (active-minibuffer-window))))) (message "Done (status=%d): %s" status full-command))))) (vc-run-delayed (run-hook-with-args 'vc-post-command-functions --=-=-=--