From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#52881: setting tab-line-separator to any value breaks clicking tabs with mouse Date: Sun, 02 Jan 2022 20:04:15 +0200 Organization: LINKOV.NET Message-ID: <86zgoe580w.fsf@mail.linkov.net> References: <868rw28qm3.fsf@mail.linkov.net> <83pmpeiisn.fsf@gnu.org> <86v8z6t78i.fsf@mail.linkov.net> <837dbmhwky.fsf@gnu.org> <86k0flf7u5.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20248"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 52881@debbugs.gnu.org, ben.sferrazza@aeonsemi.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 02 19:06:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n45FJ-0004zM-TL for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Jan 2022 19:06:17 +0100 Original-Received: from localhost ([::1]:56098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n45FI-0002gn-1l for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Jan 2022 13:06:16 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49244) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n45F5-0002gd-6P for bug-gnu-emacs@gnu.org; Sun, 02 Jan 2022 13:06:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50315) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n45F4-0004n2-9v for bug-gnu-emacs@gnu.org; Sun, 02 Jan 2022 13:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n45F4-0004iu-52 for bug-gnu-emacs@gnu.org; Sun, 02 Jan 2022 13:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Jan 2022 18:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52881 X-GNU-PR-Package: emacs Original-Received: via spool by 52881-submit@debbugs.gnu.org id=B52881.164114671118087 (code B ref 52881); Sun, 02 Jan 2022 18:06:02 +0000 Original-Received: (at 52881) by debbugs.gnu.org; 2 Jan 2022 18:05:11 +0000 Original-Received: from localhost ([127.0.0.1]:33628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n45EE-0004hf-RP for submit@debbugs.gnu.org; Sun, 02 Jan 2022 13:05:11 -0500 Original-Received: from relay12.mail.gandi.net ([217.70.178.232]:39709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n45EC-0004hK-QR for 52881@debbugs.gnu.org; Sun, 02 Jan 2022 13:05:09 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 5856A200005; Sun, 2 Jan 2022 18:05:01 +0000 (UTC) In-Reply-To: <86k0flf7u5.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 31 Dec 2021 11:21:22 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223555 Archived-At: >>> >> Eli, is it ok to push this patch to the release branch >>> >> to support longer separators: >>> > >>> > Yes, but can you make it a bit cleaner? Like having a single function >>> > to do that, and also not calling next-single-property-change twice an >>> > a row? >>> >>> I could optimize this, but I wonder why there is no simple function >>> to find a text property and its first value in the string? >> >> I don't know. We could add something like that, but that would not be >> for the release branch. > > Now fixed in Emacs 28 with an internal function. Oh no, 'get-text-property' can't replace 'get-pos-property' because it fails after 'previous-single-property-change': (progn (insert (concat "(" (propertize "1" 'tab 1) ")")) (let ((pos (previous-single-property-change (point) 'tab))) (cons (get-text-property pos 'tab) (get-pos-property pos 'tab)))) in *scratch* it returns (nil . 1). So now the recent fix was fixed on emacs-28.