all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 52881@debbugs.gnu.org, ben.sferrazza@aeonsemi.com
Subject: bug#52881: setting tab-line-separator to any value breaks clicking tabs with mouse
Date: Sun, 02 Jan 2022 20:04:15 +0200	[thread overview]
Message-ID: <86zgoe580w.fsf@mail.linkov.net> (raw)
In-Reply-To: <86k0flf7u5.fsf@mail.linkov.net> (Juri Linkov's message of "Fri,  31 Dec 2021 11:21:22 +0200")

>>> >> Eli, is it ok to push this patch to the release branch
>>> >> to support longer separators:
>>> >
>>> > Yes, but can you make it a bit cleaner?  Like having a single function
>>> > to do that, and also not calling next-single-property-change twice an
>>> > a row?
>>>
>>> I could optimize this, but I wonder why there is no simple function
>>> to find a text property and its first value in the string?
>>
>> I don't know.  We could add something like that, but that would not be
>> for the release branch.
>
> Now fixed in Emacs 28 with an internal function.

Oh no, 'get-text-property' can't replace 'get-pos-property'
because it fails after 'previous-single-property-change':

  (progn
    (insert (concat "(" (propertize "1" 'tab 1) ")"))
    (let ((pos (previous-single-property-change (point) 'tab)))
      (cons (get-text-property pos 'tab)
            (get-pos-property pos 'tab))))

in *scratch* it returns (nil . 1).  So now the recent fix was fixed on emacs-28.





      reply	other threads:[~2022-01-02 18:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-29 21:47 bug#52881: setting tab-line-separator to any value breaks clicking tabs with mouse Ben Sferrazza
2021-12-30  8:05 ` Juri Linkov
2021-12-30  8:44   ` Eli Zaretskii
2021-12-30 16:08     ` Juri Linkov
2021-12-30 16:43       ` Eli Zaretskii
2021-12-31  9:21         ` Juri Linkov
2022-01-02 18:04           ` Juri Linkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86zgoe580w.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=52881@debbugs.gnu.org \
    --cc=ben.sferrazza@aeonsemi.com \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.