From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#56772: 29.0.50; regexp-builder window is very tall when temp-buffer-resize-mode is enabled Date: Wed, 27 Jul 2022 10:35:23 +0300 Organization: LINKOV.NET Message-ID: <86zggv9fes.fsf@mail.linkov.net> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37481"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 56772@debbugs.gnu.org To: Daniel =?UTF-8?Q?Mart=C3=ADn?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 27 09:54:01 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGbrk-0009bf-Up for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Jul 2022 09:54:00 +0200 Original-Received: from localhost ([::1]:48642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGbrj-00060i-Ub for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Jul 2022 03:53:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48842) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGbnw-0002Sa-Tb for bug-gnu-emacs@gnu.org; Wed, 27 Jul 2022 03:50:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37036) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oGbnv-00048J-Hm for bug-gnu-emacs@gnu.org; Wed, 27 Jul 2022 03:50:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oGbnv-0001uH-EX for bug-gnu-emacs@gnu.org; Wed, 27 Jul 2022 03:50:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Jul 2022 07:50:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56772 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 56772-submit@debbugs.gnu.org id=B56772.16589081937285 (code B ref 56772); Wed, 27 Jul 2022 07:50:03 +0000 Original-Received: (at 56772) by debbugs.gnu.org; 27 Jul 2022 07:49:53 +0000 Original-Received: from localhost ([127.0.0.1]:55014 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGbnk-0001tP-R3 for submit@debbugs.gnu.org; Wed, 27 Jul 2022 03:49:53 -0400 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:44487) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGbni-0001t6-Pc for 56772@debbugs.gnu.org; Wed, 27 Jul 2022 03:49:51 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id C13A61BF211; Wed, 27 Jul 2022 07:49:43 +0000 (UTC) In-Reply-To: ("Daniel =?UTF-8?Q?Mart=C3=ADn?= via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\""'s message of "Tue, 26 Jul 2022 01:19:56 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238007 Archived-At: --=-=-= Content-Type: text/plain > Expected result: > > The regexp-builder window takes 4 lines, just as when > temp-buffer-resize-mode is not enabled. > > Workaround: > > Calling M-x fit-window-to-buffer after M-x regexp-builder resizes the > window successfully. Before 57354bc6 it was hard-coded to 4, so a possible fix would be (window-height . ,(+ (if header-line-format 1 0) (if tab-line-format 1 0) 4)) But a better fix is this: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=re-builder-fit-window-to-buffer.patch diff --git a/lisp/emacs-lisp/re-builder.el b/lisp/emacs-lisp/re-builder.el index 46b429ce6f..84018f06ac 100644 --- a/lisp/emacs-lisp/re-builder.el +++ b/lisp/emacs-lisp/re-builder.el @@ -369,7 +369,8 @@ re-builder (get-buffer-create reb-buffer) `((display-buffer-in-direction) (direction . ,dir) - (dedicated . t)))))) + (dedicated . t) + (window-height . fit-window-to-buffer)))))) (font-lock-mode 1) (reb-initialize-buffer))) --=-=-= Content-Type: text/plain I don't know why it resizes to less lines with tab-line-mode, but this is a separate problem. --=-=-=--