bug#56772: 29.0.50; regexp-builder window is very tall when temp-buffer-resize-mode is enabled

[Juri Linkov <juri@linkov.net>]

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]

> Expected result:
>
> The regexp-builder window takes 4 lines, just as when
> temp-buffer-resize-mode is not enabled.
>
> Workaround:
>
> Calling M-x fit-window-to-buffer after M-x regexp-builder resizes the
> window successfully.

Before 57354bc6 it was hard-coded to 4, so a possible fix would be

              (window-height . ,(+ (if header-line-format 1 0)
                                   (if tab-line-format 1 0)
                                   4))

But a better fix is this:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: re-builder-fit-window-to-buffer.patch --]
[-- Type: text/x-diff, Size: 520 bytes --]

diff --git a/lisp/emacs-lisp/re-builder.el b/lisp/emacs-lisp/re-builder.el
index 46b429ce6f..84018f06ac 100644
--- a/lisp/emacs-lisp/re-builder.el
+++ b/lisp/emacs-lisp/re-builder.el
@@ -369,7 +369,8 @@ re-builder
             (get-buffer-create reb-buffer)
             `((display-buffer-in-direction)
               (direction . ,dir)
-              (dedicated . t))))))
+              (dedicated . t)
+              (window-height . fit-window-to-buffer))))))
     (font-lock-mode 1)
     (reb-initialize-buffer)))
 

[-- Attachment #3: Type: text/plain, Size: 95 bytes --]


I don't know why it resizes to less lines with tab-line-mode,
but this is a separate problem.