From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Finalizing 'inhibit-automatic-native-compilation' Date: Sun, 29 Jan 2023 11:46:42 +0000 Message-ID: <86zga1pnq5.fsf@gmail.com> References: <837cx8cey0.fsf@gnu.org> <83357vauh5.fsf@gnu.org> <837cx6a8me.fsf@gnu.org> <83357ua6ja.fsf@gnu.org> <83zga28ra8.fsf@gnu.org> <86v8kqpcb1.fsf@gmail.com> <83fsbt96tk.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17028"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: emacs-devel@gnu.org Cancel-Lock: sha1:BlHp+02iURW3b2Bfe+GMRTWQXEg= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 29 14:57:26 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pM8BS-0004IJ-4F for ged-emacs-devel@m.gmane-mx.org; Sun, 29 Jan 2023 14:57:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pM8Aj-00049y-RB; Sun, 29 Jan 2023 08:56:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pM697-0003EG-0Q for emacs-devel@gnu.org; Sun, 29 Jan 2023 06:46:53 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pM695-0001xB-HQ for emacs-devel@gnu.org; Sun, 29 Jan 2023 06:46:52 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1pM692-00018x-Fo for emacs-devel@gnu.org; Sun, 29 Jan 2023 12:46:48 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sun, 29 Jan 2023 08:56:32 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302747 Archived-At: On Sun 29 Jan 2023, Eli Zaretskii wrote: >> From: Andy Moreton >> Date: Sat, 28 Jan 2023 21:41:06 +0000 >> >> On Sat 28 Jan 2023, Eli Zaretskii wrote: >> >> > Can we decide that "temporarily" we will write trampolines even if >> > native-compilation was disabled, i.e. go back to what we had in Emacs >> > 28? >> >> `comp-enable-subr-trampolines' is also relevant. > > Yes, of course. > >> In bug #60996 Windows builds currently error on delete-file for a >> trampoline .eln file if inhibit-automatic-native-compilation is non-nil >> (because Windows does not allow the .eln file to be deleted while it >> is loaded as a DLL). >> >> If inhibit-automatic-native-compilation is non-nil and >> comp-enable-subr-trampolines is nil then the delete-file error is >> avoided (at a cost of losing correct handling of advised primitives). > > Removing comp-enable-subr-trampolines is not on the table. We need > that to allow users to start Emacs built with native-compilation when > libgccjit and/or Binutils are not available on the system where Emacs > is run, something that happens mostly on MS-Windows, but can also > happen elsewhere. I was not suggesting removal of comp-enable-subr-trampolines, only its use as a workaround for bug #60996, which is now fixed. AndyM