From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#63455: 30.0.50; display-buffer-in-direction is always resizing Date: Fri, 12 May 2023 20:16:20 +0300 Organization: LINKOV.NET Message-ID: <86zg69lb6v.fsf@mail.linkov.net> References: <87fs82z7cw.fsf@web.de> <77edb1db-13ad-fa1d-d1fc-7a23f0b6240d@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34529"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Michael Heerdegen , 63455@debbugs.gnu.org, dgutov@yandex.ru To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 12 19:29:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pxWa5-0008oL-VK for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 May 2023 19:29:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pxWZl-0002Ff-AC; Fri, 12 May 2023 13:29:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxWZj-0002Eq-MQ for bug-gnu-emacs@gnu.org; Fri, 12 May 2023 13:29:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pxWZj-0007hs-1L for bug-gnu-emacs@gnu.org; Fri, 12 May 2023 13:29:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pxWZi-0000lp-TL for bug-gnu-emacs@gnu.org; Fri, 12 May 2023 13:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 May 2023 17:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63455 X-GNU-PR-Package: emacs Original-Received: via spool by 63455-submit@debbugs.gnu.org id=B63455.16839124882857 (code B ref 63455); Fri, 12 May 2023 17:29:02 +0000 Original-Received: (at 63455) by debbugs.gnu.org; 12 May 2023 17:28:08 +0000 Original-Received: from localhost ([127.0.0.1]:60949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxWYq-0000k0-08 for submit@debbugs.gnu.org; Fri, 12 May 2023 13:28:08 -0400 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:41835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxWYo-0000jF-NM for 63455@debbugs.gnu.org; Fri, 12 May 2023 13:28:07 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 175F0C0004; Fri, 12 May 2023 17:27:58 +0000 (UTC) In-Reply-To: <77edb1db-13ad-fa1d-d1fc-7a23f0b6240d@gmx.at> (martin rudalics's message of "Fri, 12 May 2023 09:39:40 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261633 Archived-At: > I think you're right. In my local Emacs I removed both incarnations of > that code (the other one being in 'display-buffer--maybe-at-bottom') > long ago. There are 3 uses of 'display-buffer--maybe-at-bottom' in the Emacs source tree: 'project-kill-buffers' and 'save-buffers-kill-emacs' override the default. But 'hack-local-variables-confirm' depends on the current default value. > I can only shortly sketch how I manage things here: The end > of 'help--window-setup' has become > > (help-window-setup > (setq window (temp-buffer-window-show (current-buffer) nil t))) > (help-make-xrefs (current-buffer)) > (when (and window temp-buffer-resize-mode) > (let (resize-temp-buffer-window-inhibit) > (resize-temp-buffer-window window))))))) > > 'temp-buffer-window-show' has a third argument NO-RESIZE and its last > lines are rewritten as > > (with-selected-window window > (run-hooks 'temp-buffer-window-show-hook) > (when (and (not no-resize) temp-buffer-resize-mode) > (resize-temp-buffer-window window))) > ;; Return the window. > window)))) > > Maybe Juri can make heads or tails of this. Are these changes intended to completely remove these lines from 'display-buffer-in-direction' and 'display-buffer--maybe-at-bottom'? `(,(if temp-buffer-resize-mode '(window-height . resize-temp-buffer-window) '(window-height . fit-window-to-buffer)) ,(when temp-buffer-resize-mode '(preserve-size . (nil . t)))) I expected that only 1 line should be removed to change this to: `(,(when temp-buffer-resize-mode '(window-height . resize-temp-buffer-window)) ,(when temp-buffer-resize-mode '(preserve-size . (nil . t)))) But if all lines should be removed, then how to use it? I tried with your patch, but this doesn't resize the window: (setq temp-buffer-resize-mode t) (display-buffer (current-buffer) '((display-buffer-in-direction) . ((direction . top))))