From: Eli Zaretskii <eliz@gnu.org>
To: Theodor Thornhill <theo@thornhill.no>, Yuan Fu <casouri@gmail.com>
Cc: 70345@debbugs.gnu.org, Jacob Leeming <jacobtophatleeming@gmail.com>
Subject: bug#70345: [PATCH] 29.1.50; csharp-ts-mode indentation of if statements with single-statement body
Date: Fri, 12 Apr 2024 08:45:19 +0300 [thread overview]
Message-ID: <86zftzrv68.fsf@gnu.org> (raw)
In-Reply-To: <87o7afod31.fsf@gmail.com> (message from Jacob Leeming on Thu, 11 Apr 2024 21:32:02 +0100)
> From: Jacob Leeming <jacobtophatleeming@gmail.com>
> Date: Thu, 11 Apr 2024 21:32:02 +0100
>
> Hi all,
>
> >From emacs -Q:
>
> Evaluate this elisp to set up treesitter for csharp:
>
> (setq treesit-language-source-alist '((c-sharp
> "https://github.com/tree-sitter/tree-sitter-c-sharp" "master" "src"))
> treesit-load-name-override-list '((c-sharp
> "libtree-sitter-csharp" "tree_sitter_c_sharp"))
> major-mode-remap-alist '((csharp-mode . csharp-ts-mode)))
>
> Insert the following text into a csharp-ts-mode buffer:
>
> if (true)
> var x = 2;
>
> Try to indent the variable declaration of the function with
> indent-for-tab-command. Nothing will happen. I'd expect to see this:
>
> if (true)
> var x = 2;
>
> This issue can be fixed with the following patch:
>
> diff --git a/lisp/progmodes/csharp-mode.el b/lisp/progmodes/csharp-mode.el
> index 53c52e6..1a7d535 100644
> --- a/lisp/progmodes/csharp-mode.el
> +++ b/lisp/progmodes/csharp-mode.el
> @@ -678,7 +678,8 @@ csharp-ts-mode--indent-rules
> ((parent-is "binary_expression") parent 0)
> ((parent-is "block") parent-bol csharp-ts-mode-indent-offset)
> ((parent-is "local_function_statement") parent-bol 0)
> - ((parent-is "if_statement") parent-bol 0)
> + ((match "block" "if_statement") parent-bol 0)
> + ((parent-is "if_statement") parent-bol csharp-ts-mode-indent-offset)
> ((parent-is "for_statement") parent-bol 0)
> ((parent-is "for_each_statement") parent-bol 0)
> ((parent-is "while_statement") parent-bol 0)
Theo and Yuan, any comments?
next prev parent reply other threads:[~2024-04-12 5:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 20:32 bug#70345: [PATCH] 29.1.50; csharp-ts-mode indentation of if statements with single-statement body Jacob Leeming
2024-04-12 5:45 ` Eli Zaretskii [this message]
2024-04-14 23:02 ` Yuan Fu
2024-04-15 4:56 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-15 19:01 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-15 21:38 ` Jacob Leeming
2024-04-16 0:27 ` Dmitry Gutov
2024-04-22 8:50 ` Jacob Leeming
2024-04-25 16:04 ` Eli Zaretskii
2024-04-26 13:53 ` Jacob Leeming
2024-04-26 15:24 ` Eli Zaretskii
2024-04-27 13:10 ` john muhl
2024-04-27 15:41 ` Eli Zaretskii
2024-04-27 17:13 ` john muhl
2024-04-27 19:18 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86zftzrv68.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=70345@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=jacobtophatleeming@gmail.com \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.