From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#70725: 29.3; dired-do-touch completion Date: Tue, 07 May 2024 19:48:54 +0300 Organization: LINKOV.NET Message-ID: <86zft1h8jt.fsf@mail.linkov.net> References: <871q6kkn5o.fsf@librehacker.com> <87plu38pf6.fsf@posteo.net> <86fruzjudh.fsf@gnu.org> <87fruzwetu.fsf@posteo.net> <8634qwlrii.fsf@mail.linkov.net> <87v83r8pm3.fsf@posteo.net> <86msp38lqm.fsf@mail.linkov.net> <87r0ef8cr9.fsf@posteo.net> <87seyv6ulx.fsf@igel.home> <87msp386vn.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33430"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: christopher@librehacker.com, Eli Zaretskii , Andreas Schwab , 70725@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 07 18:55:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s4O5z-0008Rt-TX for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 May 2024 18:55:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s4O5Y-0004fS-Lv; Tue, 07 May 2024 12:54:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s4O5O-0004eS-DL for bug-gnu-emacs@gnu.org; Tue, 07 May 2024 12:54:39 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s4O5N-0008Ft-LT for bug-gnu-emacs@gnu.org; Tue, 07 May 2024 12:54:38 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s4O5l-0003p2-V3 for bug-gnu-emacs@gnu.org; Tue, 07 May 2024 12:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 May 2024 16:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70725 X-GNU-PR-Package: emacs Original-Received: via spool by 70725-submit@debbugs.gnu.org id=B70725.171510086514677 (code B ref 70725); Tue, 07 May 2024 16:55:01 +0000 Original-Received: (at 70725) by debbugs.gnu.org; 7 May 2024 16:54:25 +0000 Original-Received: from localhost ([127.0.0.1]:43626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4O5B-0003of-12 for submit@debbugs.gnu.org; Tue, 07 May 2024 12:54:25 -0400 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:37417) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4O57-0003oZ-E3 for 70725@debbugs.gnu.org; Tue, 07 May 2024 12:54:23 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 7B0DF240008; Tue, 7 May 2024 16:53:48 +0000 (UTC) In-Reply-To: <87msp386vn.fsf@posteo.net> (Thierry Volpiatto's message of "Mon, 06 May 2024 12:25:16 +0000") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284646 Archived-At: --=-=-= Content-Type: text/plain > However this doesn't explain why dired-do-touch uses a completing-read Indeed, this was an oversight. Here is the patch that replaces 'completing-read' with 'read-string': --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=dired-mark-read-string.patch diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el index a2ce3083cfe..f3343b9b637 100644 --- a/lisp/dired-aux.el +++ b/lisp/dired-aux.el @@ -658,10 +658,13 @@ dired-mark-read-string Optional arg COLLECTION is a collection of possible completions, passed as the second arg to `completing-read'." - (dired-mark-pop-up nil op-symbol files - 'completing-read - (format prompt (dired-mark-prompt arg files)) - collection nil nil initial nil default-value nil)) + (apply #'dired-mark-pop-up + nil op-symbol files + (if (eq op-symbol 'touch) 'read-string 'completing-read) + (format prompt (dired-mark-prompt arg files)) + (if (eq op-symbol 'touch) + `(,initial nil ,default-value nil) + `(,collection nil nil ,initial nil ,default-value nil)))) ;;; Cleaning a directory: flagging some backups for deletion --=-=-=--