From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71049: async-shell-command ends with "Process *Async Shell Command* finished" when remote "direct-async-process" Date: Fri, 31 May 2024 08:53:32 +0300 Message-ID: <86zfs6plwj.fsf@gnu.org> References: <3a497741-2ad0-4919-b7c9-cdb36b0eb455@gutov.dev> <87o78vf9l2.fsf@gmx.de> <86sey711m6.fsf@gnu.org> <221919a1-950e-4ef3-975d-f86078d8e105@gutov.dev> <87wmnidv3u.fsf@gmx.de> <25dad14a-397c-4052-908c-121e40bbef51@gutov.dev> <877cfhubyd.fsf@gmx.de> <608acf89-a1f9-4151-9f53-99962af87688@gutov.dev> <87jzjhvnbw.fsf@gmx.de> <50900208-34b8-4b7c-90fc-8796da6bccd6@gutov.dev> <87cyp9vlb1.fsf@gmx.de> <87fru4u06a.fsf@gmx.de> <7989cd21-7808-4416-ab0a-92e5da869a36@gutov.dev> <861q5ku956.fsf@gnu.org> <86wmncss4i.fsf@gnu.org> <0ebb5a51-8634-4f65-a384-79f82592e339@gutov.dev> <87h6egecqn.fsf@gmx.de> <727a50c7-0e50-429e-9f9a-78b5b29ff405@gutov.dev> <875xuwea52.fsf@gmx.de> <87jzjbr8ek.fsf@gmx.de> <9685d486-46fe-4947-8bb2-fb436f09048b@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33148"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael.albinus@gmx.de, 71049@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 31 07:54:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sCvDR-0008OY-Kp for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 31 May 2024 07:54:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sCvD8-00018J-KV; Fri, 31 May 2024 01:53:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sCvD6-00017t-BA for bug-gnu-emacs@gnu.org; Fri, 31 May 2024 01:53:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sCvD5-0002tf-2u for bug-gnu-emacs@gnu.org; Fri, 31 May 2024 01:53:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sCvDF-0006jf-To for bug-gnu-emacs@gnu.org; Fri, 31 May 2024 01:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 May 2024 05:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71049 X-GNU-PR-Package: emacs Original-Received: via spool by 71049-submit@debbugs.gnu.org id=B71049.171713483325878 (code B ref 71049); Fri, 31 May 2024 05:54:01 +0000 Original-Received: (at 71049) by debbugs.gnu.org; 31 May 2024 05:53:53 +0000 Original-Received: from localhost ([127.0.0.1]:52994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sCvD7-0006jI-8M for submit@debbugs.gnu.org; Fri, 31 May 2024 01:53:53 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sCvD4-0006j6-SH for 71049@debbugs.gnu.org; Fri, 31 May 2024 01:53:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sCvCo-0002sY-CB; Fri, 31 May 2024 01:53:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=1FtlLkVuuG82Pzhe8kESmtIdd5vfZEWI+P5k2WrLO90=; b=h0CPdxDiYWFw g0Fz2EIizNNUy04bsgBef3OePA56FJrurQY+3sf0kZHdesaw+yj/UAR4dPNw1+YB16DiIO6llZKOM cGAM1v/LrdYxgwk9jSCNc20bkHkv5gjUDSHMjEtGJXhNgJzreOqWPL6ZH1bQE7ttLVUzG0Fqqti1v fuy3WrvuXPObRsTouqyTzKBIP9YtGcAGtmpvEUP94oqp6SmW861KTKWVyegInvUsW/c3Mt44P6KP9 aauSV/tZuiJI2Cxb4LKiHvb0pJjr42wis0sgMiF8aXQaOGttV7jpM14lE6Kb3QR4+MIS/zpS9D4QA cr1iAiHdVngVbKuSVOZ8sg==; In-Reply-To: <9685d486-46fe-4947-8bb2-fb436f09048b@gutov.dev> (message from Dmitry Gutov on Fri, 31 May 2024 03:24:49 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286255 Archived-At: > Date: Fri, 31 May 2024 03:24:49 +0300 > Cc: Eli Zaretskii , 71049@debbugs.gnu.org > From: Dmitry Gutov > > >> Thank you. I haven't tested this personally either, but it seems like > >> this is the behavior we will want by default. > >> > >> So the proposed solution should include it, I think. > > In order to not misunderstand: you agree the solution based on > > tramp-histfile-override now, don't you? > > Just to be frank: I don't like the approach, but I do think it's better > than the status quo. In that sense, I agree with it, if none other is > accepted. > > But, well, in the meantime I came up with a couple of new solutions: > > 1) [first patch] We can add a new major mode, for 'M-&' to use instead > of the full-blown 'shell-mode' - it could be very simple: just apply > font-lock keywords and maybe set list-buffers-directory. I think I'm okay with this. (It needs to be prominently documented, of course.) But we need a documented way for people to get previous behavior if they want that. How would that work? > Problems? I suppose someone might be using shell-mode-hook to do > something in the async-shell-command output buffer, and it won't fire > anymore. Seemingly very minor concern. Can't we run shell-mode-hook inside this new mode's mode hook? Then this problem goes away. > 2) [second patch] async-shell-command could set shell--start-prog (it's > permanent-local) to `none', and then shell-mode will check for that > value, and if set to this value, skip the input ring setup. > > Downsides? Pretty ad-hoc approach. And any external code looking up this > (private) variable could be surprised by the new value. Yes, which is why I like this one less. Thanks.