From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71424: 29.3; auto-revert-use-notify buggy interaction with indirect buffers Date: Sat, 08 Jun 2024 19:27:08 +0300 Message-ID: <86zfrvbdsz.fsf@gnu.org> References: <87ed98caci.fsf@bcc32.com> <86h6e3ex13.fsf@gnu.org> <01d36245-763b-43e8-93f8-679f176fedd0@app.fastmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15492"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71424@debbugs.gnu.org To: "Aaron Zeng" , Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 08 18:28:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sFyvP-0003qC-4W for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Jun 2024 18:28:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sFyuz-0002zn-56; Sat, 08 Jun 2024 12:27:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFyux-0002yy-G7 for bug-gnu-emacs@gnu.org; Sat, 08 Jun 2024 12:27:47 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sFyux-0001yb-6n for bug-gnu-emacs@gnu.org; Sat, 08 Jun 2024 12:27:47 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sFyvC-0002Vv-Rm for bug-gnu-emacs@gnu.org; Sat, 08 Jun 2024 12:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Jun 2024 16:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71424 X-GNU-PR-Package: emacs Original-Received: via spool by 71424-submit@debbugs.gnu.org id=B71424.17178640569611 (code B ref 71424); Sat, 08 Jun 2024 16:28:02 +0000 Original-Received: (at 71424) by debbugs.gnu.org; 8 Jun 2024 16:27:36 +0000 Original-Received: from localhost ([127.0.0.1]:39301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFyul-0002Uw-UX for submit@debbugs.gnu.org; Sat, 08 Jun 2024 12:27:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFyui-0002Uc-Ui for 71424@debbugs.gnu.org; Sat, 08 Jun 2024 12:27:35 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFyuN-0001sR-J0; Sat, 08 Jun 2024 12:27:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qufLAr54+5XXpgdcywvxv8PaNKDRI0iQtdnxz5zS64k=; b=p0nZx+DfHNC/ P3xb6bcnD/rjDS08KhLFa/huSBbyc627q9hYY7djaa8PGXIirSDazZgrj5UhJdZ0dGZxp3OuGEXHk 6dWIXzTl/d1WmYcBtEEOSceKIdiK4Yw4rQx1wAgHoxo8VtO8z94vTALWeKUc3jYFkkD8JxEENB7fG DfnmO0XLDtkG6VTro7SR1F4zp7DzXDdXvHYrUH7BONhGnuSuCQ8bV7dXbYPza5e9J9ygIJe+7r7aY fTNX57uQkPwuf0S5APEFwGLmzck4W1Q0E0aOeNeC3cYnUCqbftXWfA0SiLUeud6742QUEJ8EewOhs UZhksIy9nUWJYqBj+eO3iw==; In-Reply-To: <01d36245-763b-43e8-93f8-679f176fedd0@app.fastmail.com> (z@bcc32.com) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286871 Archived-At: > Date: Sat, 08 Jun 2024 11:30:08 -0400 > From: "Aaron Zeng" > Cc: 71424@debbugs.gnu.org > > On Sat, Jun 8, 2024, at 03:03, Eli Zaretskii wrote: > > > To see that at least the basic functionality works in Emacs, I did the > > following: > > > > emacs -Q > > C-x C-f SOME-FILE RET > > M-x global-auto-revert-mode RET > > M-x clone-indirect-buffer RET > > > > Then, outside Emacs, typed from the shell prompt > > > > $ cat OTHER-FILE >> SOME-FILE > > > > where OTHER-FILE is some other existing file. After that, I saw both > > the base buffer's text and that of its indirect clone change to > > reflect the appended text. > > Indeed, while the indirect buffer is live, everything works fine. However, after you kill the indirect buffer, then the buffer no longer gets auto-reverted when you modify SOME-FILE outside Emacs. Right. Michael, is the below the correct fix? diff --git a/lisp/autorevert.el b/lisp/autorevert.el index a23d536..ab69add 100644 --- a/lisp/autorevert.el +++ b/lisp/autorevert.el @@ -378,8 +378,11 @@ auto-revert-debug (defun auto-revert-remove-current-buffer (&optional buffer) "Remove BUFFER from `auto-revert-buffer-list'. BUFFER defaults to `current-buffer'." - (setq auto-revert-buffer-list - (delq (or buffer (current-buffer)) auto-revert-buffer-list))) + (let ((buf (or buffer (current-buffer)))) + ;; Don't remove the watch if we are killing an indirect buffer. + (or (buffer-base-buffer buf) + (setq auto-revert-buffer-list + (delq buf auto-revert-buffer-list))))) ;;;###autoload (define-minor-mode auto-revert-mode @@ -639,7 +642,9 @@ auto-revert-set-timer (defun auto-revert-notify-rm-watch () "Disable file notification for current buffer's associated file." - (when-let ((desc auto-revert-notify-watch-descriptor)) + (when-let ((desc + (and (buffer-base-buffer) + auto-revert-notify-watch-descriptor))) (setq auto-revert--buffer-by-watch-descriptor (assoc-delete-all desc auto-revert--buffer-by-watch-descriptor)) (ignore-errors