From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: rudalics@gmx.at, abdo.haji.ali@gmail.com, 71386@debbugs.gnu.org
Subject: bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs
Date: Sun, 09 Jun 2024 20:58:10 +0300 [thread overview]
Message-ID: <86zfruc7qh.fsf@mail.linkov.net> (raw)
In-Reply-To: <86msnu9fhg.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 09 Jun 2024 20:46:03 +0300")
>> +(defun tab-bar-window-delete-frame (frame _kill)
>> + "Whether FRAME should be deleted when other tabs are available for that frame.
>> +Instead of deleting the frame, close the current tab.
>
> The first and the second sentences contradict each other. The first
> implies that this is a predicate which returns a boolean, whereas the
> second says that it closes the tab and negtlets to say anything about
> the return value.
>
>> +(defvar window-delete-frame-functions nil
>> + "Don't delete frame when one of functions returns t.
>> +Each of functions is called with two arguments: FRAME and KILL.
>> +The function can perform an action instead of deleting the frame.")
>
> This doc string should at least explain what is the KILL argument and
> its meaning.
I tried to improve these doc strings:
diff --git a/lisp/window.el b/lisp/window.el
index 2208346ec8c..e97557b5bb2 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -4968,6 +4968,13 @@ frame-auto-hide-function
:group 'frames
:version "26.1")
+(defvar window-delete-frame-functions nil
+ "A list of functions to handle the frame deletion.
+Each of functions is called with two arguments: FRAME and KILL where
+KILL means the buffer shown in window will be killed. When one of functions
+returns a non-nil value then `window--delete' will not delete the frame.
+The function can also perform own action instead of deleting the frame.")
+
(defun window--delete (&optional window dedicated-only kill)
"Delete WINDOW if possible.
WINDOW must be a live window and defaults to the selected one.
@@ -4982,6 +4989,10 @@ window--delete
((eq deletable 'frame)
(let ((frame (window-frame window)))
(cond
+ ((run-hook-with-args-until-success
+ 'window-delete-frame-functions
+ frame kill)
+ nil)
(kill
(delete-frame frame))
((functionp (frame-parameter frame 'auto-hide-function))
diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el
index 6ab6324540e..2f7578b842b 100644
--- a/lisp/tab-bar.el
+++ b/lisp/tab-bar.el
@@ -2659,6 +2659,17 @@ tab-switcher-mouse-select
(goto-char (posn-point (event-end event)))
(tab-switcher-select))
+\f
+(defun tab-bar-window-delete-frame (frame _kill)
+ "Handle frame deletion in `tab-bar-mode'.
+When there are more than one tab on the selected frame, then close
+the current tab. In this case return t to not delete the frame
+in `window--delete'."
+ (and tab-bar-mode (> (length (funcall tab-bar-tabs-function frame)) 1)
+ (progn (tab-bar-close-tab) t)))
+
+(add-hook 'window-delete-frame-functions #'tab-bar-window-delete-frame)
+
\f
(defun tab-bar--reusable-frames (all-frames)
(cond
next prev parent reply other threads:[~2024-06-09 17:58 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-05 23:44 bug#71386: 29.1; Frame is auto-deleted even when it has multiple tabs Al Haji-Ali
2024-06-06 5:45 ` Eli Zaretskii
2024-06-06 6:12 ` Juri Linkov
2024-06-06 9:20 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-06 10:10 ` Eli Zaretskii
2024-06-06 9:19 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-07 6:39 ` Juri Linkov
2024-06-07 8:23 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-07 17:20 ` Juri Linkov
2024-06-07 17:52 ` Eli Zaretskii
2024-06-07 18:16 ` Juri Linkov
2024-06-07 18:44 ` Al Haji-Ali
2024-06-09 16:59 ` Juri Linkov
2024-06-09 17:46 ` Eli Zaretskii
2024-06-09 17:58 ` Juri Linkov [this message]
2024-06-09 18:16 ` Eli Zaretskii
2024-06-09 18:28 ` Juri Linkov
2024-06-10 8:00 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-11 6:58 ` Juri Linkov
2024-06-11 16:26 ` Al Haji-Ali
2024-06-13 6:50 ` Juri Linkov
2024-06-12 8:57 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-13 6:53 ` Juri Linkov
2024-06-13 8:21 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-14 6:13 ` Juri Linkov
2024-06-14 17:46 ` Juri Linkov
2024-06-15 8:42 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-16 6:58 ` Juri Linkov
2024-06-16 7:52 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-16 10:50 ` Al Haji-Ali
2024-06-17 14:47 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-17 16:08 ` Al Haji-Ali
2024-06-17 16:47 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-17 17:01 ` Al Haji-Ali
2024-06-18 9:52 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-18 19:04 ` Al Haji-Ali
2024-06-19 6:24 ` Juri Linkov
2024-06-19 9:37 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-20 6:48 ` Juri Linkov
2024-06-20 9:29 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-16 16:45 ` Juri Linkov
2024-06-17 6:16 ` Juri Linkov
2024-06-17 14:47 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-07 19:50 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86zfruc7qh.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=71386@debbugs.gnu.org \
--cc=abdo.haji.ali@gmail.com \
--cc=eliz@gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.