From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input Date: Thu, 04 Jul 2024 19:04:42 +0300 Organization: LINKOV.NET Message-ID: <86zfqxqi6e.fsf@mail.linkov.net> References: <86ikxltzhx.fsf@mail.linkov.net> <861q49a8vt.fsf@gnu.org> <86y16h8olf.fsf@gnu.org> <878qyh79ov.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11723"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) Cc: jpw@gnu.org, Eshel Yaron , basil@contovou.net, 71927@debbugs.gnu.org, Eli Zaretskii , kickingvegas@gmail.com To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 04 18:15:34 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sPP7N-0002up-Bk for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Jul 2024 18:15:33 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sPP6v-0003Tp-Hd; Thu, 04 Jul 2024 12:15:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sPP6r-0003OY-39 for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 12:15:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sPP6q-0005gz-QC for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 12:15:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sPP6s-0006KV-7x for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2024 12:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jul 2024 16:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71927 X-GNU-PR-Package: emacs Original-Received: via spool by 71927-submit@debbugs.gnu.org id=B71927.172010967324251 (code B ref 71927); Thu, 04 Jul 2024 16:15:02 +0000 Original-Received: (at 71927) by debbugs.gnu.org; 4 Jul 2024 16:14:33 +0000 Original-Received: from localhost ([127.0.0.1]:42821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPP6P-0006J5-BX for submit@debbugs.gnu.org; Thu, 04 Jul 2024 12:14:33 -0400 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:46697) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sPP6O-0006Im-A3 for 71927@debbugs.gnu.org; Thu, 04 Jul 2024 12:14:32 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id D8E04C000B; Thu, 4 Jul 2024 16:14:01 +0000 (UTC) In-Reply-To: <878qyh79ov.fsf@gmx.net> (Stephen Berman's message of "Thu, 04 Jul 2024 12:06:40 +0200") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288379 Archived-At: >>> FWIW, AFAICT everything is working correctly, it's just that the >>> "Operation finished" message hides the prompt. ibuffer-do-isearch >>> should tell define-ibuffer-op not to display that message, somehow. >> >> I don't see how this could be considered "correct": the "Operation >> finished" message is supposed to be shown only after the Isearch is >> finished in all the marked buffer, not before. It looks like we need >> a function that will not return until all the buffers where searched, >> because that's what define-ibuffer-op expects. Don't you agree? It intentionally uses 'no-recursive-edit' set to t, so ibuffer-do-isearch correctly exits immediately while leaving isearch-mode enabled. > The attached patch appears to DTRT, but I only tested it briefly. > ... > (define-ibuffer-op ibuffer-do-isearch () > "Perform a `isearch-forward' in marked buffers." > (:interactive () > - :opstring "searched in" > + :no-opstring t Thanks for the patch. I confirm this is the right thing to do. Maybe instead of :no-opstring would be better to use some special value like :opstring 'no? But I'm not sure if this is better than :no-opstring.