From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: MPS: weak hash tables Date: Sat, 06 Jul 2024 16:59:55 +0300 Message-ID: <86zfqu39k4.fsf@gnu.org> References: <-plQctKgNkvp-LJ9ov2QAiXQKxd9V-hI0yz_opRGxQtbknubCjH4rH2-ymgbw_Qr1ZhB1rtlmiEW8XtuIVNr7nR_Yj20AH6WkH6kUGp68g0=@protonmail.com> <_mNcR6ailVKpYHLxgfo_tJlYGeR0AQIzQWluspYYp5_g5pIIKkHLNfFkklQQgOKNiVW8jn8NS3i2dJ7_B2Qyx9v-Dq3MQ9mP8HNL30UWsqY=@protonmail.com> <878qyf4sgm.fsf@gmail.com> <878qye3l81.fsf@gmail.com> <86ikxi4vt5.fsf@gnu.org> <871q4639z0.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35149"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, pipcet@protonmail.com, emacs-devel@gnu.org To: Helmut Eller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 06 16:00:46 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sQ5y1-0008wf-2u for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Jul 2024 16:00:45 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sQ5xH-0006ZW-Sd; Sat, 06 Jul 2024 09:59:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQ5xG-0006ZH-G8 for emacs-devel@gnu.org; Sat, 06 Jul 2024 09:59:58 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQ5xF-0008Cn-Up; Sat, 06 Jul 2024 09:59:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7q95/TafDbobX6TNfOCD/cOf2V9NESxHQT363FVa4LA=; b=Ufg8/XAbq1SV rXnYx6bda2r7jXjsODr4OqCkqSFP648GOnCAt+mfYV1uQrqceaxEyN+pb6an5qaCq0qQBc8oqop7q 2DgCE9/Umkj/BNECq2tS+7scMFmLdHScvPV4ODnpI0eTzmc7Zb4C6pGbT+kgvENikGQn5xQWvsVPQ ifsLY35jYIQ9vLQcYEJdZOzTbgzfFFGZ8MNlwOeD8YNeRRz33SuEdD6dTsZvaSxbBOLs3tLAOegM8 vzOcIbKRfmUESS9tXLjE9/i43TELkshFoGRkTNkqfvrf2/WdA8ZKH1pbiNrGds1pjXdLIblGLiiUY JD6gBYGyz4lGG526ecPHlQ==; In-Reply-To: <871q4639z0.fsf@gmail.com> (message from Helmut Eller on Sat, 06 Jul 2024 15:50:59 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321436 Archived-At: > From: Helmut Eller > Cc: gerd.moellmann@gmail.com, pipcet@protonmail.com, emacs-devel@gnu.org > Date: Sat, 06 Jul 2024 15:50:59 +0200 > > On Sat, Jul 06 2024, Eli Zaretskii wrote: > > > Isn't the call to balance_an_interval made from sweep_buffers and > > sweep_strings? We balance the intervals of the buffers and strings > > that survived GC, to make accessing these trees faster. > > I don't know; I thought that the interval tree is a red-black tree that > is always balanced. No, the interval tree is not a red-black tree. > > How did you conclude that rebalancing interval trees is needed for > > printing backtraces? > > What else could cause it in ert-test-run-tests-batch-expensive? I don't know, and I don't see why we should guess. Run that under a debugger with a breakpoint in balance_an_interval that shows the backtrace, and you will see the answer very quickly.