all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 71605@debbugs.gnu.org, luangruo@yahoo.com
Subject: bug#71605: 30.0.50; [PATCH] Support variable-width text in 'visual-wrap-prefix-mode'
Date: Fri, 02 Aug 2024 10:27:00 +0300	[thread overview]
Message-ID: <86zfpvv0zf.fsf@gnu.org> (raw)
In-Reply-To: <81d8d283-6f7e-0d09-7ae3-fb99def408d9@gmail.com> (message from Jim Porter on Sat, 27 Jul 2024 21:53:25 -0700)

> Date: Sat, 27 Jul 2024 21:53:25 -0700
> From: Jim Porter <jporterbugs@gmail.com>
> Cc: 71605@debbugs.gnu.org, Po Lu <luangruo@yahoo.com>
> 
> On 6/20/2024 12:01 PM, Jim Porter wrote:
> > On 6/20/2024 11:08 AM, Eli Zaretskii wrote:
> >> Does this mean we can close this bug, or is there anything else to do
> >> here?
> > 
> > I need to implement a new version of my patch that uses :align-to and 
> > such. So there are still things to do in this bug, but the :align-to 
> > issue that was blocking progress on this bug is now resolved.
> 
> After some time away from this bug, I've made a new version of this 
> patch which uses ':align-to' to line up the wrapped lines. All of the 
> text properties in this patch use widths defined in terms of the average 
> width for the current face (using a spec like "(N . width)"), which I 
> think should work correctly in all situations.
> 
> I've also set the min-width of the first-line prefix to ensure 
> everything lines up just right. That makes it easier to line things up 
> this way, rather than my previous brittle attempts at computing the 
> exact pixel width of the first-line prefix (that width can change for 
> all sorts of reasons).
> 
> Also attached is a test script I wrote to preview the effects of the 
> patch. If you pass an additional numeric argument on the command line 
> when loading it, it will set 'visual-wrap-extra-indent' so you can see 
> how that affects things.

LGTM, thanks.  Feel free to install on master.





  reply	other threads:[~2024-08-02  7:27 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-17  2:56 bug#71605: 30.0.50; [PATCH] Support variable-width text in 'visual-wrap-prefix-mode' Jim Porter
2024-06-17 11:37 ` Eli Zaretskii
2024-06-17 17:42   ` Jim Porter
2024-06-17 18:20     ` Eli Zaretskii
2024-06-17 18:44       ` Jim Porter
2024-06-18 11:37         ` Eli Zaretskii
2024-06-18 22:17           ` Jim Porter
2024-06-19 11:45             ` Eli Zaretskii
2024-06-19 19:53               ` Jim Porter
2024-06-20  4:58                 ` Eli Zaretskii
2024-06-20  5:37                   ` Jim Porter
2024-06-20  9:58                     ` Eli Zaretskii
2024-06-20 17:36                       ` Jim Porter
2024-06-20 18:08                         ` Eli Zaretskii
2024-06-20 19:01                           ` Jim Porter
2024-07-28  4:53                             ` Jim Porter
2024-08-02  7:27                               ` Eli Zaretskii [this message]
2024-08-04 19:24                                 ` Jim Porter
2024-06-17 14:23 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-17 16:13   ` Jim Porter
2024-06-17 18:17     ` Jim Porter
2024-06-17 19:55       ` Eli Zaretskii
2024-06-17 20:08         ` Jim Porter
2024-06-18  3:02           ` Jim Porter
2024-06-18  6:27             ` Jim Porter
2024-06-18 12:53               ` Eli Zaretskii
2024-06-18 12:39           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86zfpvv0zf.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=71605@debbugs.gnu.org \
    --cc=jporterbugs@gmail.com \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.