all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Vincenzo Pupillo <v.pupillo@gmail.com>
Cc: 73779-done@debbugs.gnu.org
Subject: bug#73779: 30.0.91; [PATCH] php-ts-mode: Better indentation and font locking, support for the latest grammar version.
Date: Sat, 19 Oct 2024 16:13:43 +0300	[thread overview]
Message-ID: <86zfn0jkvs.fsf@gnu.org> (raw)
In-Reply-To: <4928661.OV4Wx5bFTl@fedora> (message from Vincenzo Pupillo on Sat, 19 Oct 2024 14:13:33 +0200)

> From: Vincenzo Pupillo <v.pupillo@gmail.com>
> Cc: 73779@debbugs.gnu.org
> Date: Sat, 19 Oct 2024 14:13:33 +0200
> 
> > I was about to install this, but byte-compiling the modified file
> > yields the following warnings:
> > 
> >     ELC      progmodes/php-ts-mode.elc
> > 
> >   In php-ts-mode--open-statement-group-heuristic:
> >   progmodes/php-ts-mode.el:435:58: Warning: Unused lexical argument `parent'
> > progmodes/php-ts-mode.el:499:50: Warning: argument `_bol' not left unused
> > progmodes/php-ts-mode.el:518:56: Warning: argument `_bol' not left unused
> > 
> > Could you please fix these and resubmit the patch?
> 
> Sorry Eli, it's okay now.

Thanks, installed on the emacs-30 branch, and closing the bug.





      reply	other threads:[~2024-10-19 13:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-12 20:12 bug#73779: 30.0.91; [PATCH] php-ts-mode: Better indentation and font locking, support for the latest grammar version Vincenzo Pupillo
2024-10-13  4:59 ` Eli Zaretskii
2024-10-13  9:19   ` Vincenzo Pupillo
2024-10-18  6:51     ` Eli Zaretskii
2024-10-19 12:13       ` Vincenzo Pupillo
2024-10-19 13:13         ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86zfn0jkvs.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=73779-done@debbugs.gnu.org \
    --cc=v.pupillo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.