Re: On committing significant and/or controversial changes

[Eli Zaretskii <eliz@gnu.org>]

> From: Ihor Radchenko <yantar92@posteo.net>
> Cc: emacs-devel@gnu.org
> Date: Fri, 22 Nov 2024 17:26:17 +0000
> 
> 1. Make a rule that non-trivial changes and new features _must_ be
>    announced on emacs-devel at least a month (or week?) in advance
>    before committing them, and are only committed if there is no
>    significant discussion or after the discussion is settled
> 
>    If no announcement is made, they are reverted (temporarily), the
>    announcement is made, so that discussion has a chance to happen.

There's no need for a rule, since this is common sense.  All the
contributors are expected to behave like that, and if they don't, they
should expect post-factum objections, discussions, and the danger of
reverting the offending changes.

> 2. Make a rule that judgment calls are clearly indicated. If some change
>    sparks controversy/discussion and maintainer has to choose among
>    multiple solutions, such decision should be done in a separate,
>    clearly marked email, with a link to commit.

This is also common sense, and already followed.  Of course "clearly
indicated" is in the eyes of the beholder, so what is clearly
indicated" for me might not be so for others.

Bottom line: we already expect everyone to behave like that, and I see
no need to codify what common sense tells us.