From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.bugs Subject: bug#21816: elisp-mode-tests fails on a case-preserving filesystem Date: Tue, 03 Nov 2015 08:51:29 -0600 Message-ID: <86y4ef16ha.fsf@stephe-leake.org> References: <86mvuv30i1.fsf@stephe-leake.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1446562379 6895 80.91.229.3 (3 Nov 2015 14:52:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 3 Nov 2015 14:52:59 +0000 (UTC) Cc: 21816@debbugs.gnu.org To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 03 15:52:46 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ztcx2-0004cf-IR for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Nov 2015 15:52:44 +0100 Original-Received: from localhost ([::1]:49154 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ztcww-0000dP-Or for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Nov 2015 09:52:38 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44862) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtcwP-0008JA-Ky for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2015 09:52:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtcwM-0003vX-AW for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2015 09:52:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59896) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtcwM-0003vQ-7J for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2015 09:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZtcwL-0000kk-Tt for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2015 09:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Leake Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Nov 2015 14:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21816-submit@debbugs.gnu.org id=B21816.14465623152882 (code B ref 21816); Tue, 03 Nov 2015 14:52:01 +0000 Original-Received: (at 21816) by debbugs.gnu.org; 3 Nov 2015 14:51:55 +0000 Original-Received: from localhost ([127.0.0.1]:50604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZtcwE-0000kN-EE for submit@debbugs.gnu.org; Tue, 03 Nov 2015 09:51:54 -0500 Original-Received: from gproxy7-pub.mail.unifiedlayer.com ([70.40.196.235]:40795) by debbugs.gnu.org with smtp (Exim 4.80) (envelope-from ) id 1ZtcwC-0000kE-4w for 21816@debbugs.gnu.org; Tue, 03 Nov 2015 09:51:53 -0500 Original-Received: (qmail 9396 invoked by uid 0); 3 Nov 2015 14:51:50 -0000 Original-Received: from unknown (HELO cmgw4) (10.0.90.85) by gproxy7.mail.unifiedlayer.com with SMTP; 3 Nov 2015 14:51:50 -0000 Original-Received: from host114.hostmonster.com ([74.220.207.114]) by cmgw4 with id d2rl1r00s2UdiVW012roQQ; Tue, 03 Nov 2015 07:51:50 -0700 X-Authority-Analysis: v=2.1 cv=IekUBwaa c=1 sm=1 tr=0 a=CQdxDb2CKd3SRg4I0/XZPQ==:117 a=CQdxDb2CKd3SRg4I0/XZPQ==:17 a=DsvgjBjRAAAA:8 a=f5113yIGAAAA:8 a=9i_RQKNPAAAA:8 a=hEr_IkYJT6EA:10 a=x_XPkuGwIRMA:10 a=qtqOOiqGOCEA:10 a=pGLkceISAAAA:8 a=T1pit3izLiN3II8zns8A:9 Original-Received: from [76.218.37.33] (port=62714 helo=TAKVER2) by host114.hostmonster.com with esmtpa (Exim 4.84) (envelope-from ) id 1Ztcw5-0002Bk-GO; Tue, 03 Nov 2015 07:51:45 -0700 In-Reply-To: (Juanma Barranquero's message of "Tue, 3 Nov 2015 11:06:57 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (windows-nt) X-Identified-User: {2442:host114.hostmonster.com:stephele:stephe-leake.org} {sentby:smtp auth 76.218.37.33 authed with stephen_leake@stephe-leake.org} X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108347 Archived-At: Juanma Barranquero writes: > On Tue, Nov 3, 2015 at 10:17 AM, Stephen Leake < > stephen_leake@stephe-leake.org> wrote: > >> Well, since this is only a problem in a test run by developers (not >> general users), we _could_ insist on that, but I agree it would be nice >> not to. > > I think it points to a problem with xrefs in general. IMO xref-location > should have a generic compare function (specialized by default on > xref-file-location) so two of them can be compared other than by `equal' > and get the right result in case-insensitive systems. And xref-item should > also have a generic compare function, whose default implementation would > use xref-compare-locations (or whatever the name) to compare its location > slots. What is the use case for these compares, other than tests? >> The canonical solution for case-insensitive string comparisons is to use >> `downcase' on both values before using `equal'. This works for me: > > It works for me too, though I get a whole bunch of warnings running the > test: > > c:/devel/emacs/repo/trunk/test/automated/elisp-mode-tests.el and > c:/Devel/emacs/repo/trunk/test/automated/elisp-mode-tests.el are the same > file Which is why I always put the right case in `load-path' :). There's probably a way (other than fixing your load-path) to suppress those warnings; ert can redirect errors in general. I did not look into it. More worrisome is this from the byte compiler: In xref-elisp-test-run: ../../../master/test/automated/elisp-mode-tests.el:185:57:Warning: Unknown slot `:location' ../../../master/test/automated/elisp-mode-tests.el:189:60:Warning: Unknown slot `:location' yet the code runs and the tests pass. Changing ":location" to "location" fixes the warning. There are also several "unused lexical arg" warnings; see the WORKAROUND comment. >> If no one objects to this, I'll commit it. > > Please do, thanks. Done. -- -- Stephe