From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Lars Brinkhoff Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] scratch/record 25aa500 5/5: Backward compatibility with pre-existing struct instances. Date: Wed, 29 Mar 2017 08:52:32 +0200 Organization: nocrew Message-ID: <86y3voh8wf.fsf@molnjunk.nocrew.org> References: <20170328192614.13038.29393@vcs0.savannah.gnu.org> <20170328192617.32EF32017F@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1490770387 8899 195.159.176.226 (29 Mar 2017 06:53:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 29 Mar 2017 06:53:07 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 29 08:53:02 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ct7TU-0001L0-LK for ged-emacs-devel@m.gmane.org; Wed, 29 Mar 2017 08:52:56 +0200 Original-Received: from localhost ([::1]:56919 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ct7Ta-0005qr-Hx for ged-emacs-devel@m.gmane.org; Wed, 29 Mar 2017 02:53:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46129) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ct7TV-0005qm-H0 for emacs-devel@gnu.org; Wed, 29 Mar 2017 02:52:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ct7TR-0004D0-HR for emacs-devel@gnu.org; Wed, 29 Mar 2017 02:52:57 -0400 Original-Received: from [195.159.176.226] (port=57079 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ct7TR-0004Cm-AY for emacs-devel@gnu.org; Wed, 29 Mar 2017 02:52:53 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1ct7TB-0007k5-0q for emacs-devel@gnu.org; Wed, 29 Mar 2017 08:52:37 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 28 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:llJb5qEaOnTQdOpNidAlGtETQYs= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213485 Archived-At: Stefan Monnier writes: >> (let ((tag (intern (format "cl-struct-%s" name))) >> (type-and-named (get name 'cl-struct-type)) >> (descs (get name 'cl-struct-slots))) >> + (if (null (car type-and-named)) >> + (setq type-and-named (cons 'record (cdr type-and-named)))) >> (cl-struct-define name nil (get name 'cl-struct-include) >> (unless (and (eq (car type-and-named) 'vector) >> (null (cadr type-and-named)) > > Hmm... if we're in this code, it means we're in the case of an old-old > struct (once compiled before we introduced cl-struct-define), so it's > definitely not using `record`s. Good, I'll remove that code. There's also a lingering FIXME that you added: (cl-defstruct (eieio--object - (:type vector) ;We manage our own tagging system. + (:type vector) ;; FIXME! ;We manage our own tagging system. (:constructor nil) As far as I can see, the struct isn't used directly. These definitions are derived from it: eieio--object-class-tag, eieio--object-class-tag, and eieio--object-num-slot. The first two just aref slot 0, and the second is 1.