From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.bugs Subject: bug#45303: #45303 [feature/native-comp] building error on Windows Date: Mon, 21 Dec 2020 22:46:58 +0000 Message-ID: <86y2hqzsil.fsf@gmail.com> References: <83k0te6c7i.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32171"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (windows-nt) To: 45303@debbugs.gnu.org Cancel-Lock: sha1:C+o8Ll8OMDs6b2FEbEyeQYkwwhk= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 21 23:48:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1krTyM-0008GZ-D0 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Dec 2020 23:48:10 +0100 Original-Received: from localhost ([::1]:49710 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1krTyL-0005cU-FS for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Dec 2020 17:48:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51650) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1krTyE-0005cN-Lf for bug-gnu-emacs@gnu.org; Mon, 21 Dec 2020 17:48:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36963) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1krTyE-0007bM-EU for bug-gnu-emacs@gnu.org; Mon, 21 Dec 2020 17:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1krTyE-0007Ez-CS for bug-gnu-emacs@gnu.org; Mon, 21 Dec 2020 17:48:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Dec 2020 22:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45303 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.160859083127770 (code B ref -1); Mon, 21 Dec 2020 22:48:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Dec 2020 22:47:11 +0000 Original-Received: from localhost ([127.0.0.1]:48508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krTxP-0007Dp-BE for submit@debbugs.gnu.org; Mon, 21 Dec 2020 17:47:11 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:43708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1krTxM-0007Dh-GO for submit@debbugs.gnu.org; Mon, 21 Dec 2020 17:47:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51480) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1krTxL-0005Vo-NU for bug-gnu-emacs@gnu.org; Mon, 21 Dec 2020 17:47:07 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]:51902) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1krTxK-0007IV-7j for bug-gnu-emacs@gnu.org; Mon, 21 Dec 2020 17:47:07 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1krTxI-0006z2-NP for bug-gnu-emacs@gnu.org; Mon, 21 Dec 2020 23:47:04 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196553 Archived-At: On Mon 21 Dec 2020, Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: > Pal Gloss writes: > >>> There are still problems related to the usage of Fdirectory_files and >>> internal_condition_case_5 I think. At least, I get a crash after the >>> bootstrap is dumped (? see attached build log) >>> >>> Debugger entered--Lisp error: (wrong-type-argument wholenump t) >> >> Despite 2526032ea954671aa48a6ad6d924df2941a8364a, this error still happens: >> Qt and Qnil should be swapped (see sed script at the bottom of the mail >> inside my build commands or the git diff in the build log). > > Hi Pal thanks for trying. > > I don't like to run or decript scripts, I like to review and apply > patches from contributors, why don't you submit one for this? :) The fix needed here is another tweak to eln_load_path_final_clean_up: the arguments for internal_condition_case_5 should end "Qnil, Qt, return_nil". After fixing that then a bootstrap build completes without crashes. Other issues noted when running the uninstalled emacs from build dir: a) The ELN compile step is very slow during bootstrap. b) The built emacs will run uninstalled (i.e. directly from the build tree), but is almost unusable as the async ELN compile make emacs very unresponsive to input. c) The .eln files for a few core .el files are built in: /native-lisp/--/*.eln The async compile puts .eln files in: $HOME/.emacs.d/eln-cache/--/*.eln Q1: Why are the compiled files not added to builddir/lisp-native ? Q2: Why are the directory and filenames so long ? Q3: Why are the directory names different ? This needs a heirarchy of files named after a hash of their content. This problem has been solved by git, mercurial etc, and it would be better to use a similar layout, and learn lessons from those tools for how to do so efficiently. Q4: Why are the lisp files not *all* precompiled as part of the build ? Q5: What can be done to improve the slow compile time ? Q6: Why are the built files so large ? For example: 47609 abbrev.el 40298 abbrev.elc 174799 abbrev-2af30c9ac0795d54ce43b6286aa259ff-a03852565cd14ed2eaa6f4159b530c2e.eln Thanks for working on this, AndyM