all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: jakanakaevangeli@chiru.no
Cc: emacs-devel@gnu.org
Subject: Re: master fb4f2aa038: * lisp/textmodes/paragraphs.el (repunctuate-sentences-filter): New function.
Date: Tue, 04 Jan 2022 20:03:36 +0200	[thread overview]
Message-ID: <86y23vml8n.fsf@mail.linkov.net> (raw)
In-Reply-To: <87r19ns9fv.fsf@miha-pc> (jakanakaevangeli@chiru.no's message of "Tue, 04 Jan 2022 18:21:56 +0100")

>> +(defun repunctuate-sentences-filter (_start _end)
>> +  "Search filter used by `repunctuate-sentences' to skip unneeded spaces.
>> +By default, it skips occurrences that already have two spaces.
>> +It is advised to put `advice-add' on this function to add more filters,
>> +for example, `(looking-back (rx (or \"e.g.\" \"i.e.\") \" \") 5)'
>> +with a set of predefined abbreviations to skip from adding two spaces."
>> +  (not (length= (match-string 4) 2)))
>
> Similarly to filter-buffer-substring-function, I believe it would be
> better if this was a variable, on which 'add-function' could be used.
> This would make it easier to set buffer locally if needed.

Thanks, good idea.  Then, for example,

#+begin_src emacs-lisp
  (add-function :after-while (local 'repunctuate-sentences-filter)
                  (lambda (start end)
                    (not (looking-back (rx (or "e.g." "i.e.") " ") 5))))
#+end_src

will be possible with:

diff --git a/lisp/textmodes/paragraphs.el b/lisp/textmodes/paragraphs.el
index fc10a0dd1b..e3b5ecbcca 100644
--- a/lisp/textmodes/paragraphs.el
+++ b/lisp/textmodes/paragraphs.el
@@ -487,6 +487,8 @@ repunctuate-sentences-filter
 with a set of predefined abbreviations to skip from adding two spaces."
   (not (length= (match-string 4) 2)))
 
+(defvar repunctuate-sentences-filter #'repunctuate-sentences-filter)
+
 (defun repunctuate-sentences (&optional no-query start end)
   "Put two spaces at the end of sentences from point to the end of buffer.
 It works using `query-replace-regexp'.  In Transient Mark mode,
@@ -507,10 +509,10 @@ repunctuate-sentences
       (unwind-protect
           (progn
             (add-function :after-while isearch-filter-predicate
-                          #'repunctuate-sentences-filter)
+                          repunctuate-sentences-filter)
             (query-replace-regexp regexp to-string nil start end))
         (remove-function isearch-filter-predicate
-                         #'repunctuate-sentences-filter)))))
+                         repunctuate-sentences-filter)))))
 
--



  reply	other threads:[~2022-01-04 18:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-04 17:21 master fb4f2aa038: * lisp/textmodes/paragraphs.el (repunctuate-sentences-filter): New function jakanakaevangeli
2022-01-04 18:03 ` Juri Linkov [this message]
2022-01-04 20:44   ` Stefan Monnier
2022-01-05 18:47     ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86y23vml8n.fsf@mail.linkov.net \
    --to=juri@jurta.org \
    --cc=emacs-devel@gnu.org \
    --cc=jakanakaevangeli@chiru.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.