From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Select completions from the minibuffer Date: Fri, 18 Mar 2022 11:27:52 +0200 Organization: LINKOV.NET Message-ID: <86y217d2j3.fsf@mail.linkov.net> References: <87v8wl35wg.fsf@gnus.org> <86k0d06dik.fsf@mail.linkov.net> <87ee3714li.fsf@gnus.org> <86r1773sb4.fsf@mail.linkov.net> <87pmmquew4.fsf@gnus.org> <86ee357wob.fsf@mail.linkov.net> <20220314090826.gyc42227jpvh4efa@Ergus> <86zglsiazs.fsf@mail.linkov.net> <20220317184701.ani7k3clp3impqwn@Ergus> <865yoc47d2.fsf@mail.linkov.net> <20220317231027.65clapwxz5qtnpm4@Ergus> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28824"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 18 10:46:17 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nV9BZ-0007PH-2M for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Mar 2022 10:46:17 +0100 Original-Received: from localhost ([::1]:43532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nV9BY-0003GP-4N for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Mar 2022 05:46:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33540) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nV9AE-00018c-Ez for emacs-devel@gnu.org; Fri, 18 Mar 2022 05:44:54 -0400 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:51535) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nV9AC-0006FR-HT for emacs-devel@gnu.org; Fri, 18 Mar 2022 05:44:54 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 556F0100011; Fri, 18 Mar 2022 09:44:47 +0000 (UTC) In-Reply-To: <20220317231027.65clapwxz5qtnpm4@Ergus> (Ergus's message of "Fri, 18 Mar 2022 00:10:27 +0100") Received-SPF: pass client-ip=217.70.178.231; envelope-from=juri@linkov.net; helo=relay11.mail.gandi.net X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_BL_SPAMCOP_NET=1.347, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287272 Archived-At: > Looking at the last line in `deactivate-mark` it seems like it is a > known issue and changing such optimization in the display engine may be > probably undesirable (Eli will confirm soon hopefully), so in your case > maybe is better to force the update on demand like in deactivate-mark: > > ``` > (defmacro with-minibuffer-completions-window (&rest body) > "Execute the forms in BODY from the minibuffer in its completions window. > When used in a minibuffer window, select the window with completions, > and execute the forms." > (declare (indent 0) (debug t)) > `(let ((window (or (get-buffer-window "*Completions*" 0) > ;; Make sure we have a completions window. > (progn (minibuffer-completion-help) > (get-buffer-window "*Completions*" 0))))) > (when window > (with-selected-window window > ,@body > (redisplay--update-cursor-face-highlight window))))) > ``` > > This seems to work. > > Is it enough? Thanks, I confirm such forcing the update fixes highlighting. But still when cursor-face-highlight-nonselected-window is nil by default, let-binding it to t has no effect: ``` (defun minibuffer-next-completion (&optional n) "Run `next-completion' from the minibuffer in its completions window." (interactive "p") (with-minibuffer-completions-window (let ((cursor-face-highlight-nonselected-window t)) (next-completion n)))) ```