From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#55110: 29.0.50; Regression in query-replace prompt Date: Sun, 15 May 2022 21:45:51 +0300 Organization: LINKOV.NET Message-ID: <86y1z2ocrk.fsf@mail.linkov.net> References: <86levtfa31.fsf@mail.linkov.net> <8735hzzl5n.fsf@gmail.com> <86tuaft1fr.fsf@mail.linkov.net> <87fslcumpq.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32641"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 55110@debbugs.gnu.org To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 15 20:47:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nqJGn-0008Gg-9R for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 15 May 2022 20:47:09 +0200 Original-Received: from localhost ([::1]:48972 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nqJGm-00074l-5w for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 15 May 2022 14:47:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45472) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nqJGg-00074b-Hp for bug-gnu-emacs@gnu.org; Sun, 15 May 2022 14:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56854) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nqJGg-0001tf-8t for bug-gnu-emacs@gnu.org; Sun, 15 May 2022 14:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nqJGg-00008g-7Q for bug-gnu-emacs@gnu.org; Sun, 15 May 2022 14:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 May 2022 18:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55110 X-GNU-PR-Package: emacs Original-Received: via spool by 55110-submit@debbugs.gnu.org id=B55110.165264038431432 (code B ref 55110); Sun, 15 May 2022 18:47:02 +0000 Original-Received: (at 55110) by debbugs.gnu.org; 15 May 2022 18:46:24 +0000 Original-Received: from localhost ([127.0.0.1]:50751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqJG4-0008Ak-F2 for submit@debbugs.gnu.org; Sun, 15 May 2022 14:46:24 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:57289) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nqJG2-00084S-SB for 55110@debbugs.gnu.org; Sun, 15 May 2022 14:46:23 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 4252CFF803; Sun, 15 May 2022 18:46:14 +0000 (UTC) In-Reply-To: <87fslcumpq.fsf@gmail.com> (Augusto Stoffel's message of "Sat, 14 May 2022 18:02:09 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:232340 Archived-At: >> So maybe a buffer-local value of `isearch-filter-predicate' >> in the minibuffer would help. > > Yes, that indeed solves the problem. See attached patch. Thanks, pushed. >> Also I recommend to make all hooks in `minibuffer-lazy-highlight-setup' >> local by adding the argument LOCAL to add-hook/remove-hook. > > Indeed, the minibuffer lazy highlight feature is currently incompatible > with recursive minibuffers. The patch fixes that as well. > > There's a caveat, though: isearch in a recursive minibuffer is again > affected by the presence of an inappropriate filter function. Fixing > that in a robust way might require a bigger refactoring of the lazy > highlight feature, I think. Another option might be to make > `replace--region-filter' also check for the value of `(current-buffer)'. I see no problem to fix this because every minibuffer uses own buffer, so they have separate buffer-local variables.