From: Stephen Leake <stephen_leake@stephe-leake.org>
To: "João Távora" <joaotavora@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>, Dmitry Gutov <dgutov@yandex.ru>
Subject: Re: [SPAM UNSURE] Re: * lisp/progmodes/eglot.el (eglot--connect): Use project-name
Date: Thu, 24 Nov 2022 13:30:36 -0800 [thread overview]
Message-ID: <86y1s0hwg3.fsf@stephe-leake.org> (raw)
In-Reply-To: <CALDnm51du96D68s-YB_=1HAmSMXkN9y8vBeHmaaci4hTpurFgA@mail.gmail.com> ("João Távora"'s message of "Thu, 24 Nov 2022 14:43:57 +0000")
João Távora <joaotavora@gmail.com> writes:
> You use an fboundp check for the project-name function recently
> added to project.el.
>
> This is not necessary in eglot.el, since it already depends on the
> project.el :core ELPA package. eglot.el is itself such a package.
> So you must merely bump the "Version:" of the project.el package in
> that file and then make eglot.el reference the new version in its
> "Package-Requires:".
Ok.
> Of course you should/could ask permission before bumping
> project.el's version (or not, depends on Dmitry's policy)
Right.
> PS: When about to apply a patch to eglot.el, even one where I
> have already approved the underlying idea, I would appreciate
> it if you could just shoot me a personal mail showing the full
> contents of the patch.
Ok
--
-- Stephe
next prev parent reply other threads:[~2022-11-24 21:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 14:43 * lisp/progmodes/eglot.el (eglot--connect): Use project-name João Távora
2022-11-24 21:30 ` Stephen Leake [this message]
2022-11-24 21:35 ` Dmitry Gutov
2022-11-25 9:28 ` João Távora
2022-11-25 15:14 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86y1s0hwg3.fsf@stephe-leake.org \
--to=stephen_leake@stephe-leake.org \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.