From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#66686: 29.1.90; Bug in log-view-mode-menu Date: Sun, 22 Oct 2023 20:48:14 +0300 Organization: LINKOV.NET Message-ID: <86y1futuox.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25464"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) To: 66686@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 22 19:50:50 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qucbB-0006Vi-Pm for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Oct 2023 19:50:49 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qucaz-0006wC-EX; Sun, 22 Oct 2023 13:50:37 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qucaw-0006w1-LU for bug-gnu-emacs@gnu.org; Sun, 22 Oct 2023 13:50:34 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qucaw-00053R-DE for bug-gnu-emacs@gnu.org; Sun, 22 Oct 2023 13:50:34 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qucbO-0003Vx-GU for bug-gnu-emacs@gnu.org; Sun, 22 Oct 2023 13:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Oct 2023 17:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 66686 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.169799706113500 (code B ref -1); Sun, 22 Oct 2023 17:51:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Oct 2023 17:51:01 +0000 Original-Received: from localhost ([127.0.0.1]:48038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qucbN-0003Vg-2D for submit@debbugs.gnu.org; Sun, 22 Oct 2023 13:51:01 -0400 Original-Received: from lists.gnu.org ([2001:470:142::17]:58014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qucbI-0003VP-E5 for submit@debbugs.gnu.org; Sun, 22 Oct 2023 13:50:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qucaj-0006vU-OY for bug-gnu-emacs@gnu.org; Sun, 22 Oct 2023 13:50:21 -0400 Original-Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qucah-0004vw-D4 for bug-gnu-emacs@gnu.org; Sun, 22 Oct 2023 13:50:21 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id C6BD31C0002 for ; Sun, 22 Oct 2023 17:50:15 +0000 (UTC) X-GND-Sasl: juri@linkov.net Received-SPF: pass client-ip=2001:4b98:dc4:8::225; envelope-from=juri@linkov.net; helo=relay5-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272990 Archived-At: --=-=-= Content-Type: text/plain Eli, is it ok to install this bug fix on the emacs-29 branch? It fails when using the context menu in a log-view buffer, but doesn't fail when using it on the main menu bar (maybe because it catches errors in the menu). --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=log-view-mode-menu.patch diff --git a/lisp/vc/log-view.el b/lisp/vc/log-view.el index e6eb6a5b973..af24fcfd398 100644 --- a/lisp/vc/log-view.el +++ b/lisp/vc/log-view.el @@ -163,14 +163,14 @@ log-view-mode-menu :help "Go to the previous count'th log message"] ["Next File" log-view-file-next :help "Go to the next count'th file" - :active (derived-mode-p vc-cvs-log-view-mode - vc-rcs-log-view-mode - vc-sccs-log-view-mode)] + :active (derived-mode-p 'vc-cvs-log-view-mode + 'vc-rcs-log-view-mode + 'vc-sccs-log-view-mode)] ["Previous File" log-view-file-prev :help "Go to the previous count'th file" - :active (derived-mode-p vc-cvs-log-view-mode - vc-rcs-log-view-mode - vc-sccs-log-view-mode)])) + :active (derived-mode-p 'vc-cvs-log-view-mode + 'vc-rcs-log-view-mode + 'vc-sccs-log-view-mode)])) (defvar log-view-mode-hook nil "Hook run at the end of `log-view-mode'.") --=-=-=--