From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Unhelpful text in C-h v search-default-mode Date: Wed, 25 Oct 2023 09:43:10 +0300 Organization: LINKOV.NET Message-ID: <86y1fr8ao1.fsf@mail.linkov.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37867"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 25 08:51:42 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qvXjw-0009kh-HA for ged-emacs-devel@m.gmane-mx.org; Wed, 25 Oct 2023 08:51:40 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qvXiy-0006gc-Mg; Wed, 25 Oct 2023 02:50:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvXiw-0006g1-E8 for emacs-devel@gnu.org; Wed, 25 Oct 2023 02:50:38 -0400 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvXiu-0006Ok-8U for emacs-devel@gnu.org; Wed, 25 Oct 2023 02:50:38 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 8E5CC60007; Wed, 25 Oct 2023 06:50:29 +0000 (UTC) In-Reply-To: (Alan Mackenzie's message of "Tue, 24 Oct 2023 09:45:59 +0000") X-GND-Sasl: juri@linkov.net Received-SPF: pass client-ip=217.70.183.195; envelope-from=juri@linkov.net; helo=relay3-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:311827 Archived-At: > In a recent master branch Emacs, (not with -Q), from an info buffer, I > did C-h v search-default-mode. The text printed in *Help* included this: > > Its value is > # > Original value was nil > Local in buffer *info*<3>; global value is nil > > .. This is quite frankly entirely unhelpful; it gives no way to find out > what the lambda is, in particular, no way to get to its source code. It > isn't even possible to disassemble the function. > > After a good deal of searching, I think I found the pertinent source > code, but am not sure, namely in isearch.el L4685, right near the end: > > (setq-local isearch-fold-quotes-mode--state > (buffer-local-set-state > search-default-mode > (lambda (string &optional _lax) > (thread-last > (regexp-quote string) > (replace-regexp-in-string "`" "[`‘]") > (replace-regexp-in-string "'" "['’]") > (replace-regexp-in-string "\"" "[\"""]"))))) > > .. Here, this customisable variable search-default-mode gets set to a > lambda function. The problem could have been avoided if the extra effort > to come up with a symbol for this function had been expended, and the > function written separately as a defun with a name. > > I am asking people to be careful not to use lambda forms like this, > instead always prefering defun and a name. A good name for the new function would be 'isearch-fold-quotes-regexp' modeled after the existing 'isearch-symbol-regexp', 'char-fold-to-regexp'.