From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#66948: [PATCH] Add Completion Preview mode Date: Thu, 09 Nov 2023 09:25:22 +0200 Organization: LINKOV.NET Message-ID: <86y1f7cs8l.fsf@mail.linkov.net> References: <87lebcqcof.fsf@posteo.net> <86a5rrcqd3.fsf@mail.linkov.net> <86zfzqeoix.fsf@mail.linkov.net> <86msvobtjm.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36611"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Dmitry Gutov , Philip Kaludercic , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , 66948@debbugs.gnu.org To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 09 08:38:48 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r0zcl-0009MB-8V for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Nov 2023 08:38:47 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r0zcX-00052S-FI; Thu, 09 Nov 2023 02:38:34 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r0zcO-0004wE-ID for bug-gnu-emacs@gnu.org; Thu, 09 Nov 2023 02:38:25 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r0zcO-0007LS-AO for bug-gnu-emacs@gnu.org; Thu, 09 Nov 2023 02:38:24 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r0zcz-00053r-Vv for bug-gnu-emacs@gnu.org; Thu, 09 Nov 2023 02:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Nov 2023 07:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66948 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66948-submit@debbugs.gnu.org id=B66948.169951549219373 (code B ref 66948); Thu, 09 Nov 2023 07:39:01 +0000 Original-Received: (at 66948) by debbugs.gnu.org; 9 Nov 2023 07:38:12 +0000 Original-Received: from localhost ([127.0.0.1]:46714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r0zcC-00052P-JR for submit@debbugs.gnu.org; Thu, 09 Nov 2023 02:38:12 -0500 Original-Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]:45325) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r0zc9-000528-PC for 66948@debbugs.gnu.org; Thu, 09 Nov 2023 02:38:11 -0500 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 8DBA6E0006; Thu, 9 Nov 2023 07:37:22 +0000 (UTC) In-Reply-To: (Eshel Yaron's message of "Wed, 08 Nov 2023 16:44:30 +0100") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274033 Archived-At: >>> While testing more, I noticed one strange thing, >>> I don't know if it's intended to work this way. > [...] >> This appears to be a general problem with `completion-in-region-mode`, >> that it keeps TAB bound to `completion-at-point` after a partial >> completion, so I don't think we should attempt to handle it in >> `completion-preview` specifically. > > Let me know if you think otherwise, that `completion-preview` should > handle this case specifically, although I'm pretty convinced that it's > the behavior of `completion-in-region-mode` that's not quite right here. This looks like a problem of `completion-in-region-mode` indeed. > Either way, I'm attaching an new patch (v3) that includes > `backward-delete-char-untabify` in `completion-preview-commands` to > provide a nicer OOTB experience for Elisp (as you suggested), along with > a couple of minor optimizations and documentation improvements. Let's see what Eli decides to do with your new package.