From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 4b79c80c999 1/2: New function 'sort-on' Date: Fri, 02 Feb 2024 17:47:51 +0200 Message-ID: <86y1c250m0.fsf@gnu.org> References: <170688047526.14693.2994051491358257471@vcs2.savannah.gnu.org> <20240202132756.4272CC0EFE7@vcs2.savannah.gnu.org> <87cytej4hy.fsf@daniel-mendler.de> <86zfwi52m1.fsf@gnu.org> <87a5oij399.fsf@daniel-mendler.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36426"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Feb 02 16:48:44 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rVvmV-0009BJ-Dc for ged-emacs-devel@m.gmane-mx.org; Fri, 02 Feb 2024 16:48:43 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rVvlp-0007uf-0U; Fri, 02 Feb 2024 10:48:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVvll-0007uO-2O for emacs-devel@gnu.org; Fri, 02 Feb 2024 10:47:57 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVvlj-0006it-NJ; Fri, 02 Feb 2024 10:47:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=e0LXuydK7nWfKFM9xqgX8cMljiWNclPj6BkowKtdaBk=; b=WahzFAAwqJt9 FafGEZ+Y+Ij/vzT/88niQR7NQAYzjQaRUJkb9l6K/WUx24SufdPA6aV1G+8oVKitqwRcMNTRsONtI wie/hJzfD826aZMaHUjSXIMNmqcXRAgOIX0sl4hV/n+HPevZMT65L7qbT4vJiOwXMi9hJIZoqO3y8 pFdXTNc34W1XirIkn/AQxDAqNe/ATtFyzmUU2KE4Y3FfjRRq8WPjfQxPh3qshWOxQ2N5TzIWjtydM 9bWrelJtH596yeMi6szYFQkMxkp2dXbfzY/WQE5UnZMazt13MVFVsQcEXQFuVeG1KWNsZFnCa7F3y t3lkCeGXb8Aad/JwP1PyTQ==; In-Reply-To: <87a5oij399.fsf@daniel-mendler.de> (message from Daniel Mendler on Fri, 02 Feb 2024 16:26:58 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315758 Archived-At: > From: Daniel Mendler > Cc: emacs-devel@gnu.org > Date: Fri, 02 Feb 2024 16:26:58 +0100 > > Eli Zaretskii writes: > > >> Would this function fit into the seq library, named seq-sort-on? > > > > "Fit" in what sense? > > The function works with other sequence types too and it seems a good > idea to collect sequence-related functionality in seq.el. OK, but the result is always a list, something seq.el doesn't do. > > This function can only sort lists, so at least from that aspect its > > place is not in seq.el. In addition, I see no reason to have it > > preloaded. > > No, in the current form, the function works on vectors too. It always > returns a list though. But maybe it makes sense to generalize it such > that it returns the same type as the argument. I see no reason to preload this function, anyway. > > I've put it in sort.el because the function 'sort' is there. > > No, sort is defined in src/fns.c. And your point is...?