From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= Newsgroups: gmane.emacs.devel Subject: Re: master 8d4a8b7dfd0: ; Re-apply accidentally reverted commit Date: Mon, 18 Mar 2024 08:31:44 +0100 Message-ID: <86y1aghu73.fsf@kevinlegouguec.net> References: <171071192781.29642.16850908468499185478@vcs2.savannah.gnu.org> <20240317214528.4FA50C1CB35@vcs2.savannah.gnu.org> <87zfuwpapo.fsf@pub.pink> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4183"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Cc: emacs-devel@gnu.org To: john muhl Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Mar 18 08:32:56 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rm7UM-0000n6-Pj for ged-emacs-devel@m.gmane-mx.org; Mon, 18 Mar 2024 08:32:54 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rm7TM-0006PO-4z; Mon, 18 Mar 2024 03:31:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rm7TJ-0006P8-Hl for emacs-devel@gnu.org; Mon, 18 Mar 2024 03:31:50 -0400 Original-Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rm7TI-00057d-49 for emacs-devel@gnu.org; Mon, 18 Mar 2024 03:31:49 -0400 Original-Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-413f4cb646dso24863165e9.1 for ; Mon, 18 Mar 2024 00:31:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710747105; x=1711351905; darn=gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=zvWxUUfC/nnt7eIC+j8zLLnf9Bks/GAjDVUfFHyg1WY=; b=jOuX8pwaKhSTbXQVubCXAnYpwddmpZie/UOTxCUo/YbkF6lH5sUGCZs4GEzaVs9Os7 q634GQwPmT1B2hoYb6PkZujqOR6dd81HLzbC9SZZM4s5BCGt21ugNBXjsYFdurPWD1DO rgfGQ0YJFrGwpK7SVtEVl46JhtKeF4JSwsfP0bSGkf9EPYiLclQ30q/lp/QuxUJThVc0 vaBL/aXQ6oyitlrPC2LTpz4NpDP7RVZNORTi8RpcYgxAOgX+x2DOj60vNnmgS8zxY+13 bWa2Xynf27RskmXnfDNKvjX1oY2eaBQKkJSPfWNAbWyuWjte1mps30K0f6DyYuWNiauS sFPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710747105; x=1711351905; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=zvWxUUfC/nnt7eIC+j8zLLnf9Bks/GAjDVUfFHyg1WY=; b=p4NWfZd0J7o4Ab43ZJnawRleCOQRn7I/nUKpJg9+OIB+GeFxp9koWSKGrtWrQQ9BCH Y7OrAuhpiZK23x5dDQUbkMYYUQ3J9v1y40fEOmig+ilClTXe7BLgL0JaQB04hYFztyEC p9ZZKQVvKauzv8UHrc3JqalVy+PkAZl0JuSAtmjDBTyfext+kJmVQUPCUpKLT+oX5p6e QrcnkFQ38IvAufkMRQDhH1IGLOQeQz5mhp9xsoElx3IhH1Ky/NaxpHDcHyqAm5U3MvGv gPurQs1AVMPkfhwyEhp8Ve+oNUOcF7w60Jj1awPNaKrMW7faP5L9X2lY/UDWCuBfGVOw sOfg== X-Gm-Message-State: AOJu0YzjidQ+lFrAlNExcnb4yV2t9RfBWHGrLNVgcRpHNrM+q7dODFLR jdCAw15IpKpfGGfjGqNrpfjW6ZOK0MyMCX4oCvvknzTtI2s3qrtt191B4SaxNgA= X-Google-Smtp-Source: AGHT+IGq6CBjyI7+IZWpPEefTBwCq82ZzfQOTV7wvqOMluSRJvY9TbIX8VqVHpjEjGxf+9jd5q7jnQ== X-Received: by 2002:a05:600c:46cd:b0:413:f28d:1cf2 with SMTP id q13-20020a05600c46cd00b00413f28d1cf2mr8315506wmo.4.1710747105562; Mon, 18 Mar 2024 00:31:45 -0700 (PDT) Original-Received: from kevinlegouguec.net (kevinlegouguec.net. [151.80.149.237]) by smtp.gmail.com with ESMTPSA id fc6-20020a05600c524600b00413ee7921b4sm14824902wmb.15.2024.03.18.00.31.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Mar 2024 00:31:45 -0700 (PDT) In-Reply-To: <87zfuwpapo.fsf@pub.pink> (john muhl's message of "Sun, 17 Mar 2024 19:50:20 -0500") Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=kevin.legouguec@gmail.com; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:317158 Archived-At: john muhl writes: > The test you added here fails when run by a user that doesn=E2=80=99t have > Git configured. When run by such a user the =E2=80=98git commit -mFirst= =E2=80=99 > command errors which causes the test to fail: Yikes, thanks for the heads-up. I see vc-tests.el sets the corresponding environment variables (EMAIL, GIT_AUTHOR_NAME, GIT_COMMITTER_NAME); it would probably make sense to teach vc-git-test--with-repo to do the same. Will get to it later in the day, if no-one beats me to it. Apologies for the disruption.