From: Eli Zaretskii <eliz@gnu.org>
To: "Mattias Engdegård" <mattias.engdegard@gmail.com>
Cc: 69709@debbugs.gnu.org, dmitry@gutov.dev,
gerd.moellmann@gmail.com, monnier@iro.umontreal.ca
Subject: bug#69709: `sort` interface improvement and universal ordering predicate
Date: Fri, 29 Mar 2024 15:06:05 +0300 [thread overview]
Message-ID: <86y1a1dyz6.fsf@gnu.org> (raw)
In-Reply-To: <7219B5AB-4EA7-4050-92AE-7FB949D6D415@gmail.com> (message from Mattias Engdegård on Fri, 29 Mar 2024 11:59:39 +0100)
> From: Mattias Engdegård <mattias.engdegard@gmail.com>
> Date: Fri, 29 Mar 2024 11:59:39 +0100
> Cc: Dmitry Gutov <dmitry@gutov.dev>,
> Eli Zaretskii <eliz@gnu.org>,
> 69709@debbugs.gnu.org,
> Gerd Möllmann <gerd.moellmann@gmail.com>
>
> 25 mars 2024 kl. 12.11 skrev Mattias Engdegård <mattias.engdegard@gmail.com>:
>
> > The plan is to add scratch/sort-key to master in a few days if no serious issues turn up.
>
> Plan executed.
Thanks.
I have a few comments/questions about value<:
. The description of value< says "lexicographic order" about some
types, but I think that is not clear enough, and we should tell
explicitly how the comparison works in those cases. AFAIU, the
corresponding elements are compared by recursively calling value<
for them? And what happens if one has more elements than the other?
These are all questions that popped up when I read the new text,
and I think they should be answered in the text.
. AFAICT, no ordering is defined for overlays, and I wonder why. I
think this could be very useful; we certainly sort overlays in C in
several places.
. Various fine details about value< are never mentioned: the fact
that there's a limit to recursion, the special treatment of nil in
some cases, etc. I think we should document them, at least in the
doc string if not in the manual as well.
next prev parent reply other threads:[~2024-03-29 12:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-10 13:28 bug#69709: `sort` interface improvement and universal ordering predicate Mattias Engdegård
2024-03-10 14:09 ` Eli Zaretskii
2024-03-10 14:56 ` Mattias Engdegård
2024-03-20 19:01 ` Mattias Engdegård
2024-03-20 19:37 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-21 14:55 ` Mattias Engdegård
2024-03-21 14:54 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-22 20:55 ` Dmitry Gutov
2024-03-23 14:58 ` Mattias Engdegård
2024-03-23 17:39 ` Dmitry Gutov
2024-03-23 20:09 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-23 23:19 ` Dmitry Gutov
2024-03-23 23:25 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-25 11:11 ` Mattias Engdegård
2024-03-29 10:59 ` Mattias Engdegård
2024-03-29 11:38 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-29 11:52 ` Mattias Engdegård
2024-05-17 12:29 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-17 17:49 ` Mattias Engdegård
2024-03-29 12:06 ` Eli Zaretskii [this message]
2024-03-29 15:02 ` Mattias Engdegård
2024-03-29 15:35 ` Eli Zaretskii
2024-03-29 16:13 ` Mattias Engdegård
2024-03-29 18:09 ` Eli Zaretskii
2024-03-10 15:48 ` Dmitry Gutov
2024-03-10 15:56 ` Mattias Engdegård
2024-03-10 16:03 ` Dmitry Gutov
2024-03-10 16:46 ` Mattias Engdegård
2024-03-10 16:55 ` Eli Zaretskii
2024-03-10 17:54 ` Dmitry Gutov
2024-03-11 7:01 ` Gerd Möllmann
2024-04-14 14:03 ` Aris Spathis
2024-04-14 16:26 ` Eli Zaretskii
2024-04-14 16:33 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86y1a1dyz6.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=69709@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=gerd.moellmann@gmail.com \
--cc=mattias.engdegard@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.