all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: mr.meowking@anche.no, 70016@debbugs.gnu.org
Subject: bug#70016: Emacs 29.3 treesit-parser-list function parameters differ from the master branch
Date: Sat, 06 Apr 2024 12:17:21 +0300	[thread overview]
Message-ID: <86y19q3l5q.fsf@gnu.org> (raw)
In-Reply-To: <70BB120D-0394-4A8F-8A40-62D767DF14BC@gmail.com> (message from Yuan Fu on Wed, 27 Mar 2024 21:47:12 -0700)

> From: Yuan Fu <casouri@gmail.com>
> Date: Wed, 27 Mar 2024 21:47:12 -0700
> Cc: Meow King <mr.meowking@anche.no>,
>  70016@debbugs.gnu.org
> 
> > On Mar 26, 2024, at 12:25 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> > 
> >> Cc: casouri@gmail.com
> >> Date: Tue, 26 Mar 2024 11:23:00 +0800
> >> From:  Meow King via "Bug reports for GNU Emacs,
> >> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> >> 
> >> I think it may be a bug (accidentally change code?) so I report it here.
> >> 
> >> Emacs 29.3 treesit-parser-list only accepts one parameter (i.e. BUFFER),
> >> but the treesit-parser-list on the latest Master Branch doesn't change,
> >> accepting three optional parameters. 
> > 
> > According to "git log", it was a deliberate change.
> > 
> > Yuan, why did we change the signature, and why isn't tyhis called out
> > in NEWS?
> 
> I believe we only changed the signature from one optional arg to three optional args, on master. Treesit-parser-list never had one mandatory arg.
> 
> We changed the signature to three optional args to a) allow users to get parsers for a specific language, and b) allow users to get parsers with a specific tag. Parser tags are used by local parsers.
> 
> I should have added a NEWS entry, but apparently I forgot :-) Sorry about that. I’ll add it, along with other functions that I said I’ll wait a bit more before documenting (it’s about time).

Ping! Could you please do these documentation changes now?

Thanks.





  reply	other threads:[~2024-04-06  9:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-26  3:23 bug#70016: Emacs 29.3 treesit-parser-list function parameters differ from the master branch Meow King via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-26 19:25 ` Eli Zaretskii
2024-03-28  4:47   ` Yuan Fu
2024-04-06  9:17     ` Eli Zaretskii [this message]
2024-04-08  6:29       ` Yuan Fu
     [not found] <87edbvds12.fsf@anche.no>
2024-03-28  7:06 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86y19q3l5q.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=70016@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=mr.meowking@anche.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.