all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: James Thomas via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 70994@debbugs.gnu.org
Cc: Eric Abrahamsen <eric@ericabrahamsen.net>,
	Stefan Kangas <stefankangas@gmail.com>
Subject: bug#70994: [PATCH] Make cache regeneration work in group names with /
Date: Wed, 22 May 2024 10:21:42 +0530	[thread overview]
Message-ID: <86y182bg9t.fsf@gmx.net> (raw)
In-Reply-To: <87le428xvg.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Tue, 21 May 2024 17:59:47 -0700")

Eric Abrahamsen wrote:

> Stefan Kangas <stefankangas@gmail.com> writes:
>
>> James Thomas via "Bug reports for GNU Emacs, the Swiss army knife of
>> text editors" <bug-gnu-emacs@gnu.org> writes:
>>
>>> Reproduction steps for bug:
>>>
>>> - emacs -Q
>>> - (setq gnus-secondary-select-methods
>>>     '((nnatom "github.com/vedang/pdf-tools/commits.atom")))
>>>   (setq gnus-select-method '(nnnil ""))
>>> - M-x gnus
>>> - Open a message in the new group and press *
>>> - Add the cache virtual server (info "(gnus) Creating a Virtual Server")
>>> - ^ (server buffer) and: g on the cache
>>> - RET to open (fails)
>>>
>>> This is a possible fix that I've tested only on my (limited) setup, for
>>> now:
>>
>> Eric, what do you think of the below patch?
>
> Thanks for the bump...
>
> James, wasn't this what bug#69517 was supposed to be fixing?

You're right, but that was specifically the 'cache'. In regenerate, all
it sees is that the backend is nnml and there's nothing else special
about the server.

> I'm still feeling like we're patching pinhole leaks in a fundamentally
> broken system.

Sorry if my patch made you think so, but I don't feel that way 🙂. This
feature is just tangential and things like slashes in group names are
bound to complicate things.

But let me see if I can whip up an alternative patch that does things in
a simpler way (I did say: 'possible' patch). One thing to decide is
whether '%'s are uncommon enough in group names to warrant special
treatment in a backend as fundamental as nnml.

Regards,
James





  reply	other threads:[~2024-05-22  4:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-17  4:56 bug#70994: [PATCH] Make cache regeneration work in group names with / James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-18 22:14 ` Stefan Kangas
2024-05-22  0:59   ` Eric Abrahamsen
2024-05-22  4:51     ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-05-24  1:26       ` Eric Abrahamsen
2024-08-08  1:16         ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-24  8:25           ` Eli Zaretskii
2024-08-24  9:24             ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-07  7:23               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86y182bg9t.fsf@gmx.net \
    --to=bug-gnu-emacs@gnu.org \
    --cc=70994@debbugs.gnu.org \
    --cc=eric@ericabrahamsen.net \
    --cc=jimjoe@gmx.net \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.