From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71284: 30.0.50; [PATCH] Add support for outline-minor-mode to Eshell Date: Fri, 31 May 2024 09:05:30 +0300 Message-ID: <86y17qplcl.fsf@gnu.org> References: <048207b3-4d91-34cd-8e2d-ccf41b7bd832@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18231"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71284@debbugs.gnu.org, juri@linkov.net To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 31 08:07:25 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sCvQD-0004Wb-1G for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 31 May 2024 08:07:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sCvPh-0002Vx-H4; Fri, 31 May 2024 02:06:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sCvPf-0002VQ-N2 for bug-gnu-emacs@gnu.org; Fri, 31 May 2024 02:06:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sCvPf-0005SZ-FC for bug-gnu-emacs@gnu.org; Fri, 31 May 2024 02:06:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sCvPp-0001P2-Ui for bug-gnu-emacs@gnu.org; Fri, 31 May 2024 02:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 May 2024 06:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71284 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71284-submit@debbugs.gnu.org id=B71284.17171355645298 (code B ref 71284); Fri, 31 May 2024 06:07:01 +0000 Original-Received: (at 71284) by debbugs.gnu.org; 31 May 2024 06:06:04 +0000 Original-Received: from localhost ([127.0.0.1]:52999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sCvOt-0001NN-Mp for submit@debbugs.gnu.org; Fri, 31 May 2024 02:06:03 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sCvOn-0001Mn-N6 for 71284@debbugs.gnu.org; Fri, 31 May 2024 02:06:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sCvOV-0005HG-2e; Fri, 31 May 2024 02:05:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=c6O7ur4bn9MJSHhJbI76SUs1xJ+n0pBUmsHHDfxT2S0=; b=DVc7m4R83zRx 9W4Cm7GjiQGA57rH1bkvc21sIq4rAKtV7LAa7ZyZyf7b8BEGJqzDk7Y506JQF6348+gdTzfQGkJ6c W1gAW+Jl/0614hur5/MbEUHoW/E48DEV4zGdojGr68iA4b0fFOXA9N3z4HqFvkDSKNcOatD9tXFOZ ShCai5Kt66J3I0KSAbhPbou5C0AAfyyGQ2Dj19oIIo4WzShjIU9akCwOe6P2Do1rS140LhMklGKge U6yFrVs/VG+8/bWcbrmPySbA9FX0lc8aDRu8Mp2CkiXNUlbGRFlg2jEXk+r3upwllhmQIuld+C4+F q96bN0MNZbJjEi2MaDTt6Q==; In-Reply-To: <048207b3-4d91-34cd-8e2d-ccf41b7bd832@gmail.com> (message from Jim Porter on Thu, 30 May 2024 22:18:44 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286256 Archived-At: > Cc: juri@linkov.net > Date: Thu, 30 May 2024 22:18:44 -0700 > From: Jim Porter > > This patch adds support for outline-minor-mode to Eshell. When enabled, > this will just add outline buttons to the prompt (as the top level), and > one to the start of the output (as level 2). Thanks. > diff --git a/doc/misc/eshell.texi b/doc/misc/eshell.texi > index 873d14aff32..071a2e59191 100644 > --- a/doc/misc/eshell.texi > +++ b/doc/misc/eshell.texi > @@ -2967,12 +2967,6 @@ Bugs and ideas > > @item Support zsh's ``Parameter Expansion'' syntax, i.e., @samp{$@{@var{name}:-@var{val}@}} > > -@item Create a mode @code{eshell-browse} > - > -It would treat the Eshell buffer as an outline. Collapsing the outline > -hides all of the output text. Collapsing again would show only the > -first command run in each directory > - > @item Allow other revisions of a file to be referenced using @samp{file@{rev@}} > > This would be expanded by @code{eshell-expand-file-name} (see above). > diff --git a/etc/NEWS b/etc/NEWS > index 3c672ffed8f..b5d4c9cfe6e 100644 > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -877,6 +877,9 @@ can make it executable like other shell scripts: > > #!/usr/bin/env -S emacs --batch -f eshell-batch-file > > +--- > +*** Eshell now supports 'outline-minor-mode'. This is what I call "anti-documentation": the text you removed, which described a non-existing feature, told more about the feature than the text you added after implementing it ;-) Seriously, though: since it is completely un-obvious what would outline-minor-mode mean for command-line-oriented modes like Eshell, both NEWS and the Eshell manual should say at least a couple of words about what that does. We cannot get away by just mentioning the support and keeping silent about the rest.