From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 71284@debbugs.gnu.org, juri@linkov.net
Subject: bug#71284: 30.0.50; [PATCH] Add support for outline-minor-mode to Eshell
Date: Fri, 31 May 2024 09:05:30 +0300 [thread overview]
Message-ID: <86y17qplcl.fsf@gnu.org> (raw)
In-Reply-To: <048207b3-4d91-34cd-8e2d-ccf41b7bd832@gmail.com> (message from Jim Porter on Thu, 30 May 2024 22:18:44 -0700)
> Cc: juri@linkov.net
> Date: Thu, 30 May 2024 22:18:44 -0700
> From: Jim Porter <jporterbugs@gmail.com>
>
> This patch adds support for outline-minor-mode to Eshell. When enabled,
> this will just add outline buttons to the prompt (as the top level), and
> one to the start of the output (as level 2).
Thanks.
> diff --git a/doc/misc/eshell.texi b/doc/misc/eshell.texi
> index 873d14aff32..071a2e59191 100644
> --- a/doc/misc/eshell.texi
> +++ b/doc/misc/eshell.texi
> @@ -2967,12 +2967,6 @@ Bugs and ideas
>
> @item Support zsh's ``Parameter Expansion'' syntax, i.e., @samp{$@{@var{name}:-@var{val}@}}
>
> -@item Create a mode @code{eshell-browse}
> -
> -It would treat the Eshell buffer as an outline. Collapsing the outline
> -hides all of the output text. Collapsing again would show only the
> -first command run in each directory
> -
> @item Allow other revisions of a file to be referenced using @samp{file@{rev@}}
>
> This would be expanded by @code{eshell-expand-file-name} (see above).
> diff --git a/etc/NEWS b/etc/NEWS
> index 3c672ffed8f..b5d4c9cfe6e 100644
> --- a/etc/NEWS
> +++ b/etc/NEWS
> @@ -877,6 +877,9 @@ can make it executable like other shell scripts:
>
> #!/usr/bin/env -S emacs --batch -f eshell-batch-file
>
> +---
> +*** Eshell now supports 'outline-minor-mode'.
This is what I call "anti-documentation": the text you removed, which
described a non-existing feature, told more about the feature than the
text you added after implementing it ;-)
Seriously, though: since it is completely un-obvious what would
outline-minor-mode mean for command-line-oriented modes like Eshell,
both NEWS and the Eshell manual should say at least a couple of words
about what that does. We cannot get away by just mentioning the
support and keeping silent about the rest.
next prev parent reply other threads:[~2024-05-31 6:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 5:18 bug#71284: 30.0.50; [PATCH] Add support for outline-minor-mode to Eshell Jim Porter
2024-05-31 6:05 ` Eli Zaretskii [this message]
2024-05-31 19:33 ` Jim Porter
2024-06-01 5:58 ` Eli Zaretskii
2024-05-31 6:51 ` Juri Linkov
2024-05-31 20:02 ` Jim Porter
2024-06-02 6:37 ` Juri Linkov
2024-06-03 4:34 ` Jim Porter
2024-06-03 6:45 ` Juri Linkov
2024-06-06 1:52 ` Jim Porter
2024-06-06 6:19 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86y17qplcl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=71284@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.