From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Adding indent-bars to ELPA Date: Thu, 25 Jul 2024 08:11:18 +0300 Message-ID: <86y15q5a4p.fsf@gnu.org> References: <864j8e7gl5.fsf@gnu.org> <3769876B-384A-4882-8228-E6CA9DF9D22A@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27943"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: JD Smith Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 25 07:11:58 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sWqli-00074z-Bi for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Jul 2024 07:11:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sWql8-0004HG-Vl; Thu, 25 Jul 2024 01:11:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWql7-0004H3-Nd for emacs-devel@gnu.org; Thu, 25 Jul 2024 01:11:21 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWql7-00073x-DK; Thu, 25 Jul 2024 01:11:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=mGspxoOC5Gl3R+oB+VkN2dLFX7Gimb3C4jFLsPNUsAo=; b=CPPqMnQcoHVA eWXpv9mdruK7pGTEp5HzWINSALfYw6Z8LMddEkP3A6Z04hY+flRA46QPfyxzd6sqh5+9x43V7MWFI AD0nyjpCjh1YQRBnmqLe60Wrnk0QfOLE8Tg1I+oKFcUo1P2yojDckKrW3SZzLa8riErg13ZvHWnuE lG2fjDgiLqAdXPIdkBCmfz5IWnUbm2Dc77HW+kaAJroQ4MyG4hWoQtovvs1DOAHJG+SkORm75Tqk7 z7DiAdg3EiHpVflteX2Niako/EUcEsoZBaCZD/Jx3LPsKo409BohDaxOfJYXjhosHSS7bLTJkCGXL TF2RroytXRMKPViZAY1Aiw==; In-Reply-To: <3769876B-384A-4882-8228-E6CA9DF9D22A@gmail.com> (message from JD Smith on Wed, 24 Jul 2024 15:32:21 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322067 Archived-At: > From: JD Smith > Date: Wed, 24 Jul 2024 15:32:21 -0400 > Cc: emacs-devel > > > It seems to work well, but has some problems with RTL text. To see > > this, visit xdisp.c, turn on the mode, then go to around line 1900, > > set bidi-paragraph-direction to 'right-to-left', and scroll up and > > down several times: you will see broken bars, both with > > indent-bars-prefer-character nil and non-nil. > > Hmm, I can say it's definitely never been tested with RTL. Is that a mode people typically use for column-oriented content like code or config files? Do you mean broken bars in the top partially displayed line? I don't see any artifacts in RTL other than this, but I can't rule out build-dependent issues of course. RTL text is generally for human-readable text, not for program source. But (a) I see no reason why this feature must never be supported for text files (think Org, for example), and (b) these problems indicate some subtle issues with display stuff in the package, so I'd suggest at least to understand why they happen, if not fix them -- it could well be that this is just a tip of some larger iceberg. As for where I see broken bars: yes, they are at the top, but at least with indent-bars-prefer-character I saw them crop up in the middle as well, after I scrolled up and down several times. I think I saw them also with indent-bars-prefer-character nil, but I'm less sure.