all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: JD Smith <jdtsmith@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Adding indent-bars to ELPA
Date: Thu, 25 Jul 2024 08:11:18 +0300	[thread overview]
Message-ID: <86y15q5a4p.fsf@gnu.org> (raw)
In-Reply-To: <3769876B-384A-4882-8228-E6CA9DF9D22A@gmail.com> (message from JD Smith on Wed, 24 Jul 2024 15:32:21 -0400)

> From: JD Smith <jdtsmith@gmail.com>
> Date: Wed, 24 Jul 2024 15:32:21 -0400
> Cc: emacs-devel <emacs-devel@gnu.org>
> 
> > It seems to work well, but has some problems with RTL text.  To see
> > this, visit xdisp.c, turn on the mode, then go to around line 1900,
> > set bidi-paragraph-direction to 'right-to-left', and scroll up and
> > down several times: you will see broken bars, both with
> > indent-bars-prefer-character nil and non-nil.
> 
> Hmm, I can say it's definitely never been tested with RTL.  Is that a mode people typically use for column-oriented content like code or config files?  Do you mean broken bars in the top partially displayed line?  I don't see any artifacts in RTL other than this, but I can't rule out build-dependent issues of course.

RTL text is generally for human-readable text, not for program source.
But (a) I see no reason why this feature must never be supported for
text files (think Org, for example), and (b) these problems indicate
some subtle issues with display stuff in the package, so I'd suggest
at least to understand why they happen, if not fix them -- it could
well be that this is just a tip of some larger iceberg.

As for where I see broken bars: yes, they are at the top, but at least
with indent-bars-prefer-character I saw them crop up in the middle as
well, after I scrolled up and down several times.  I think I saw them
also with indent-bars-prefer-character nil, but I'm less sure.



  reply	other threads:[~2024-07-25  5:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-24 18:33 Adding indent-bars to ELPA JD Smith
2024-07-24 19:08 ` Eli Zaretskii
2024-07-24 19:30   ` [External] : " Drew Adams
2024-07-24 19:32   ` JD Smith
2024-07-25  5:11     ` Eli Zaretskii [this message]
2024-07-25 12:44       ` JD Smith
2024-09-14 13:33 ` JD Smith
2024-09-14 14:38   ` Stefan Kangas
2024-09-14 17:45     ` Bar drawing in display engine, master indent-spacing variable JD Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86y15q5a4p.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jdtsmith@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.