From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72426: 29.2.50; comint-pager doesn't affect async-shell-command Date: Tue, 06 Aug 2024 21:02:00 +0300 Message-ID: <86y159o7hj.fsf@gnu.org> References: <86sevmupgo.fsf@gnu.org> <86bk29vcof.fsf@gnu.org> <8634nlv82c.fsf@gnu.org> <864j7xpsc9.fsf@gnu.org> <091182cc-9667-7740-9712-9affe3a2548e@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22079"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sbaugh@janestreet.com, 72426@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 06 20:05:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sbOYa-0005d0-8y for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Aug 2024 20:05:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sbOY4-0002qg-85; Tue, 06 Aug 2024 14:04:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbOY2-0002qO-Cw for bug-gnu-emacs@gnu.org; Tue, 06 Aug 2024 14:04:38 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sbOY1-00022Y-Rv for bug-gnu-emacs@gnu.org; Tue, 06 Aug 2024 14:04:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=CtwxjFCFdnqT930pu1oezHecNC6bu4p1rjW2gqIHv7U=; b=FwG0zzt+KmH7+dCobdQwuDuPgvvkBYNvpaRPepW72v45Fe8zEzDWjzzm+YJ8ZUYPdeOK4LzsaQ2SAaIDe8D+amVOVzpfZeENwk69XVhxTybSHV41kqNF4H3BWMUNuJ2ig+RI4uYXUNMn5422/BDqsF4RYH8pgV3txUsVbgT6DJ6608FIpcivVpHj5blFV5qkCiNRclwZnlFt1/p6a7fzv+Wd1/sNzCNYgNzRZ3h05NpcaFxxv7zEz/QHMo2Vr9sdiCOWlDt8x71ccnh2wYaJGSKCT7SyFaSHqf6rUWCKZnqzmYKYc1GtTmQFxWXbyj5v+mcsWNnwxelt2frEWig+Ug==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sbOYP-0005RW-TL for bug-gnu-emacs@gnu.org; Tue, 06 Aug 2024 14:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Aug 2024 18:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72426 X-GNU-PR-Package: emacs Original-Received: via spool by 72426-submit@debbugs.gnu.org id=B72426.172296748420876 (code B ref 72426); Tue, 06 Aug 2024 18:05:01 +0000 Original-Received: (at 72426) by debbugs.gnu.org; 6 Aug 2024 18:04:44 +0000 Original-Received: from localhost ([127.0.0.1]:33001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbOY8-0005Qd-5g for submit@debbugs.gnu.org; Tue, 06 Aug 2024 14:04:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbOY6-0005QM-DI for 72426@debbugs.gnu.org; Tue, 06 Aug 2024 14:04:42 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sbOVX-0001mv-3o; Tue, 06 Aug 2024 14:02:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=CtwxjFCFdnqT930pu1oezHecNC6bu4p1rjW2gqIHv7U=; b=dHshNcgwvYF/ 1HUA2Ll/lGQgtj+rgkGxUEc38/dytzjb6AOA2LLKCN2oDjAAhrGpqT7AqK9I3+gUQTuTM6Ug4eVFY nyJk5DdMge6vsk2Idf8B/Eba2y8DBWFcSl/NTOBLxxT1DX/up08UYNPpzM2O5D3iQLF3Twgb2mqhk KIhnhe7m4Hz9TI63wnrPwRHET6ZQVdD9/88/Anvg+0seV2yizP5BR9sPj8vOaaKey1M42RyI0Rwy3 Frm7saFBl1Nj/qRF6tNoZgo1mkEuD6rt1kzjm8nXMbzHEALlM6lAlJW9H4jeZYzq6OgpcY8kx3bLm FyEaQ6Wi19g2zgKVKH3vBA==; In-Reply-To: <091182cc-9667-7740-9712-9affe3a2548e@gmail.com> (message from Jim Porter on Tue, 6 Aug 2024 09:29:34 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289849 Archived-At: > Date: Tue, 6 Aug 2024 09:29:34 -0700 > Cc: 72426@debbugs.gnu.org > From: Jim Porter > > On 8/6/2024 8:46 AM, Eli Zaretskii wrote: > >> From: Spencer Baugh > >> Cc: 72426@debbugs.gnu.org > >> Date: Tue, 06 Aug 2024 11:33:47 -0400 > >> > >> Anyway, can we just remove comint-pager for now, to avoid adding > >> something broken that has to be maintained? I can try it again for > >> Emacs 31. > > > > I think it's too late for that, sorry. It is already supported in > > Eshell, and Emacs 30 is frozen for such changes anyway. > > For what it's worth, from the perspective of Eshell, I see the current > implementation as a half-measure that makes things better, but may be > obviated by a better implementation (e.g. setting PAGER in startup.el). > While it's disappointing to have a not-quite-right solution make it to > 30.1, I don't think that solution paints us into a corner either: it > doesn't make it any harder for us to make the startup.el change for 31.1. > > On the plus(?) side, it looks like the only place 'comint-pager' is > mentioned is in the Eshell manual (and the docstrings, of course). So > since we're not really "advertising" this option, and since I think it > would still be useful even with the startup.el change, I don't think we > have to worry too much. We can just consider the underlying issue to be > something we'll (try to) fix in 31. Yes, I think the fix will have to be postponed to Emacs 31, and meanwhile we need to test the fix well enough to be sure it (a) fixes the problem and (b) doesn't cause new ones. There's a lesson to be learned here, but I'll leave to each one of use to spell it out to him/herself.